-
Notifications
You must be signed in to change notification settings - Fork 29k
[SPARK-31357][SQL][WIP] Catalog API for view metadata #28147
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Test build #120941 has finished for PR 28147 at commit
|
View catalog resolution. View catalog SQL DDL implementations. TODO: - unit tests - SHOW VIEWS
|
Test build #120954 has finished for PR 28147 at commit
|
|
Test build #120987 has finished for PR 28147 at commit
|
|
Test build #120997 has finished for PR 28147 at commit
|
Delete ViewReservedProperties. Move view property constants to ViewCatalog.
|
Test build #121096 has finished for PR 28147 at commit
|
|
@cloud-fan @dongjoon-hyun @brkyvz Could you comment on this WIP PR? Go or no-go? Need more clarifications? Even though it is labeled as WIP, the code is pretty stable and in production for over 6 months. |
|
We're closing this PR because it hasn't been updated in a while. This isn't a judgement on the merit of the PR in any way. It's just a way of keeping the PR queue manageable. |
What changes were proposed in this pull request?
These view SQL DDLs will be done in follow-up PRs:
Most changes are pretty surgical. Please review the view substitution rule.
View substitution
Propose a new
ViewSubstitutionrule that takes a different approach than the current AnalysisContext. Here are some highlights:currentCatalogis still registered. Other than that, we have to assume registered catalogs have not undergone any breaking change between view creation and usage.TODO: viewQueryColumnNames
Propose viewQueryColumnNames to be stored in view properties just as it is currently in Hive metastore table properties. If not in view properties, we can derive from schema field names.
Why are the changes needed?
Support view catalog in DataSourceV2. Details in SPIP.
Does this PR introduce any user-facing change?
How was this patch tested?
TODO: new unit tests
Regression