-
Notifications
You must be signed in to change notification settings - Fork 29k
[SPARK-3629][Doc] improve spark on yarn doc #2813
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
… follows the config options when works with yarn. In addition, add some explainations about yarn-cluster mode and yarn-client mode.
|
Can one of the admins verify this patch? |
|
can someone verify this patch? |
|
Can one of the admins verify this patch? |
|
It's not possible to see what text you changed since the text was also moved. I am not sure it helps to move the text. Is it possible to see your changes in place? You could create a 'table of contents' of links at the top instead. Don't worry about 'verifying the patch' yet; Jenkins won't test until you're whitelisted but there is nothing to unit test. |
|
@ssjssh could you possibly make the changes suggested? |
|
I do think that it would be helpful to re-arrange this page so the high-level "here's how to run on YARN" comes before the big configuration table (I've spoken with a couple of users who would prefer that to the current page). |
|
@ssjssh could you reorganize your PR to 2 commits: one for the addition or modification, the other for moving the text. |
|
@ssjssh would you have time to work on this, if not can we close this? |
|
Can one of the admins verify this patch? |
|
If this isn't going to be rebased and split up, do you mind closing this PR? |
Right now running-on-yarn.md starts off with a big list of config options, and only then tells you how to submit an app. It would be better to put that part and the packaging part first, and the config options only at the end�. Besides I add some explainations about yarn-cluster and yarn-client mode
https://issues.apache.org/jira/browse/SPARK-3629