Skip to content

Conversation

@ssjssh
Copy link

@ssjssh ssjssh commented Oct 15, 2014

Right now running-on-yarn.md starts off with a big list of config options, and only then tells you how to submit an app. It would be better to put that part and the packaging part first, and the config options only at the end�. Besides I add some explainations about yarn-cluster and yarn-client mode

https://issues.apache.org/jira/browse/SPARK-3629

ssjssh added 5 commits October 15, 2014 22:22
… follows the config options when works with yarn. In addition, add some explainations about yarn-cluster mode and yarn-client mode.
@AmplabJenkins
Copy link

Can one of the admins verify this patch?

@ssjssh ssjssh changed the title improve spark on yarn doc(issus 3629 on jira) [SPARK-3629][Doc] mprove spark on yarn doc Oct 15, 2014
@ssjssh ssjssh changed the title [SPARK-3629][Doc] mprove spark on yarn doc [SPARK-3629][Doc] improve spark on yarn doc Oct 15, 2014
@ssjssh
Copy link
Author

ssjssh commented Oct 16, 2014

can someone verify this patch?

@AmplabJenkins
Copy link

Can one of the admins verify this patch?

@srowen
Copy link
Member

srowen commented Oct 24, 2014

It's not possible to see what text you changed since the text was also moved. I am not sure it helps to move the text. Is it possible to see your changes in place? You could create a 'table of contents' of links at the top instead. Don't worry about 'verifying the patch' yet; Jenkins won't test until you're whitelisted but there is nothing to unit test.

@tgravescs
Copy link
Contributor

@ssjssh could you possibly make the changes suggested?

@JoshRosen
Copy link
Contributor

I do think that it would be helpful to re-arrange this page so the high-level "here's how to run on YARN" comes before the big configuration table (I've spoken with a couple of users who would prefer that to the current page).

@zsxwing
Copy link
Member

zsxwing commented Dec 24, 2014

@ssjssh could you reorganize your PR to 2 commits: one for the addition or modification, the other for moving the text.

@tgravescs
Copy link
Contributor

@ssjssh would you have time to work on this, if not can we close this?

@AmplabJenkins
Copy link

Can one of the admins verify this patch?

@srowen
Copy link
Member

srowen commented Feb 26, 2015

If this isn't going to be rebased and split up, do you mind closing this PR?

@asfgit asfgit closed this in 9168259 Feb 28, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants