[SPARK-30973][SQL]ScriptTransformationExec should wait for the termination #28098
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
@dongjoon-hyun |
Contributor
Author
|
Can one of the admins verify this patch? |
Member
|
The error is not from |
Contributor
Author
|
Resolved by |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
In
org.apache.spark.sql.hive.execution.ScriptTransformationExec, when check error, sometimes we can't catch write error in subproc, when callcheckFailureAndPropagatewe should always wait for subproc stopFor UT I added, when without code change in ScriptTransformExec will always got error like below
Why are the changes needed?
Catch error in script transform
Does this PR introduce any user-facing change?
NO
How was this patch tested?
Added UT