[SPARK-31321][SQL] Remove SaveMode check in v2 FileWriteBuilder #28090
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Test build #120668 has finished for PR 28090 at commit
|
| private val options = info.options() | ||
| private var mode: SaveMode = _ | ||
|
|
||
| def mode(mode: SaveMode): WriteBuilder = { |
Member
There was a problem hiding this comment.
@yaooqinn . Technically, removal of dead code is not a bug fix. Please re-category this as an Improvement.
|
|
||
| val fs = path.getFileSystem(hadoopConf) | ||
| mode match { | ||
| case SaveMode.ErrorIfExists if fs.exists(path) => |
Member
There was a problem hiding this comment.
Could you give me the pointer where handles this?
Member
Author
There was a problem hiding this comment.
Member
|
cc @cloud-fan |
Contributor
|
I'm OK to remove dead code, this was probably leftover when we remove |
Member
Author
thanks, referenced the related PR #25876 and updated the PR description |
Contributor
|
thanks, merging to master/3.0! |
cloud-fan
pushed a commit
that referenced
this pull request
Apr 2, 2020
### What changes were proposed in this pull request? The `SaveMode` is resolved before we create `FileWriteBuilder` to build `BatchWrite`. In #25876, we removed save mode for DSV2 from DataFrameWriter. So that the `mode` method is never used which makes `validateInputs` fail determinately without `mode` set. ### Why are the changes needed? rm dead code. ### Does this PR introduce any user-facing change? no ### How was this patch tested? existing tests. Closes #28090 from yaooqinn/SPARK-31321. Authored-by: Kent Yao <[email protected]> Signed-off-by: Wenchen Fan <[email protected]> (cherry picked from commit 1ce584f) Signed-off-by: Wenchen Fan <[email protected]>
Member
|
Thank you, @cloud-fan and @yaooqinn . |
sjincho
pushed a commit
to sjincho/spark
that referenced
this pull request
Apr 15, 2020
### What changes were proposed in this pull request? The `SaveMode` is resolved before we create `FileWriteBuilder` to build `BatchWrite`. In apache#25876, we removed save mode for DSV2 from DataFrameWriter. So that the `mode` method is never used which makes `validateInputs` fail determinately without `mode` set. ### Why are the changes needed? rm dead code. ### Does this PR introduce any user-facing change? no ### How was this patch tested? existing tests. Closes apache#28090 from yaooqinn/SPARK-31321. Authored-by: Kent Yao <[email protected]> Signed-off-by: Wenchen Fan <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
The
SaveModeis resolved before we createFileWriteBuilderto buildBatchWrite.In #25876, we removed save mode for DSV2 from DataFrameWriter. So that the
modemethod is never used which makesvalidateInputsfail determinately withoutmodeset.Why are the changes needed?
rm dead code.
Does this PR introduce any user-facing change?
no
How was this patch tested?
existing tests.