[SPARK-31308][PySpark] Merging pyFiles to files argument for Non-PySpark applications #28077
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
|
Maybe we need a unit test too. But let me wait for some comments first. |
HyukjinKwon
reviewed
Mar 31, 2020
Member
|
I think it's fine. cc @vanzin and @jerryshao |
Member
|
Hi, @viirya . This PR title looks too broad. Could you be more specific by excluding the scope of SPARK-24377 ?
|
|
Test build #120622 has finished for PR 28077 at commit
|
viirya
changed the title
|
Test build #120628 has finished for PR 28077 at commit
|
Member
Author
|
retest this please |
|
Test build #120631 has finished for PR 28077 at commit
|
dongjoon-hyun
approved these changes
Apr 1, 2020
Member
|
Merged to master. Thank you, @viirya and @HyukjinKwon . |
sjincho
pushed a commit
to sjincho/spark
that referenced
this pull request
Apr 15, 2020
…ark applications ### What changes were proposed in this pull request? This PR (SPARK-31308) proposed to add python dependencies even it is not Python applications. ### Why are the changes needed? For now, we add `pyFiles` argument to `files` argument only for Python applications, in SparkSubmit. Like the reason in apache#21420, "for some Spark applications, though they're a java program, they require not only jar dependencies, but also python dependencies.", we need to add `pyFiles` to `files` even it is not Python applications. ### Does this PR introduce any user-facing change? Yes. After this change, for non-PySpark applications, the Python files specified by `pyFiles` are also added to `files` like PySpark applications. ### How was this patch tested? Manually test on jupyter notebook or do `spark-submit` with `--verbose`. ``` Spark config: ... (spark.files,file:/Users/dongjoon/PRS/SPARK-PR-28077/a.py) (spark.submit.deployMode,client) (spark.master,local[*]) ``` Closes apache#28077 from viirya/pyfile. Lead-authored-by: Liang-Chi Hsieh <[email protected]> Co-authored-by: Liang-Chi Hsieh <[email protected]> Signed-off-by: Dongjoon Hyun <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
This PR (SPARK-31308) proposed to add python dependencies even it is not Python applications.
Why are the changes needed?
For now, we add
pyFilesargument tofilesargument only for Python applications, in SparkSubmit. Like the reason in #21420, "for some Spark applications, though they're a java program, they require not only jar dependencies, but also python dependencies.", we need to addpyFilestofileseven it is not Python applications.Does this PR introduce any user-facing change?
Yes. After this change, for non-PySpark applications, the Python files specified by
pyFilesare also added tofileslike PySpark applications.How was this patch tested?
Manually test on jupyter notebook or do
spark-submitwith--verbose.