Skip to content

[SPARK-31278][SS] Fix StreamingQuery output rows metric #28040

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
brkyvz wants to merge 15 commits into from
Closed

[SPARK-31278][SS] Fix StreamingQuery output rows metric #28040

Changes from 1 commit
Commits
Show all changes
15 commits
Select commit Hold shift + click to select a range
7def4de
Fix StreamingQuery output rows metric
brkyvz Mar 26, 2020
b57aa74
add more tests
brkyvz Mar 26, 2020
4655611
fix broken test
brkyvz Mar 27, 2020
6e1f90f
Fix tests
brkyvz Mar 28, 2020
62044dc
rename progress variable
brkyvz Mar 28, 2020
5fbbf41
revert changes
brkyvz Mar 29, 2020
d7792fd
rename field
brkyvz Mar 30, 2020
d501127
Add retry for 50 times to test flakiness
brkyvz Apr 2, 2020
68848d9
fix comment
brkyvz Apr 2, 2020
1cf1a3c
Change test to avoid no-data microbatches
brkyvz Apr 3, 2020
2c9ed55
make test more robust
brkyvz Apr 3, 2020
3822aed
remove 50 retries
brkyvz Apr 4, 2020
786d921
Update StreamingAggregationSuite.scala
brkyvz Apr 4, 2020
9bd4445
Save
brkyvz Apr 7, 2020
68bf147
Merge branch 'sinkMetrics' of github.com:brkyvz/spark into sinkMetrics
brkyvz Apr 7, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion sql/core/src/test/scala/org/apache/spark/sql/streaming/StreamingAggregationSuite.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -226,7 +226,7 @@ class StreamingAggregationSuite extends StateStoreMetricsTest with Assertions {
AssertOnQuery { _.stateOperatorProgresses.head.numRowsTotal === 1 },
AssertOnQuery { _.lastExecutedBatch.sink.numOutputRows == 0 },
AddData(inputData, 10, 12, 14),
AdvanceManualClock(1000L), // watermark = 5, runs with the just added data
AdvanceManualClock(1000L), // watermark = 0, runs with the just added data
Copy link
Contributor

@HeartSaVioR HeartSaVioR Apr 2, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's just remove watermark here in comment as you've done with further AdvanceManualClock

CheckAnswer(), // watermark = 5
AssertOnQuery { _.stateNodes.size === 1 },
AssertOnQuery { _.stateNodes.head.metrics("numOutputRows").value === 0 },
Expand Down