[SPARK-25202][SQL][FOLLOW-UP] Keep the old parameter name 'pattern' at split in Scala API #27756
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
HyukjinKwon
changed the title
HyukjinKwon
changed the title
cloud-fan
approved these changes
Mar 2, 2020
|
Test build #119151 has finished for PR 27756 at commit
|
Member
|
retest this please |
maropu
approved these changes
Mar 2, 2020
|
Test build #119165 has finished for PR 27756 at commit
|
srowen
approved these changes
Mar 2, 2020
MaxGekk
reviewed
Mar 2, 2020
dongjoon-hyun
approved these changes
Mar 2, 2020
viirya
approved these changes
Mar 2, 2020
Member
Author
|
Oops, mistake. I was removing my old branches. |
Member
Author
|
Thanks guys. I am going to merge this because the last change was comment-only. I locally ran the Scala linter to make sure. |
Member
Author
|
Merged to master and branch-3.0. |
HyukjinKwon
added a commit
that referenced
this pull request
Mar 3, 2020
…t split in Scala API ### What changes were proposed in this pull request? To address the concern pointed out in #22227. This will make `split` source-compatible by removing minimal cosmetic changes. ### Why are the changes needed? For source compatibility. ### Does this PR introduce any user-facing change? No (it will prevent potential user-facing change from the original PR) ### How was this patch tested? Unittest was changed (in order for us to detect that source compatibility easily). Closes #27756 from HyukjinKwon/SPARK-25202. Authored-by: HyukjinKwon <[email protected]> Signed-off-by: HyukjinKwon <[email protected]> (cherry picked from commit 3956e95) Signed-off-by: HyukjinKwon <[email protected]>
sjincho
pushed a commit
to sjincho/spark
that referenced
this pull request
Apr 15, 2020
…t split in Scala API ### What changes were proposed in this pull request? To address the concern pointed out in apache#22227. This will make `split` source-compatible by removing minimal cosmetic changes. ### Why are the changes needed? For source compatibility. ### Does this PR introduce any user-facing change? No (it will prevent potential user-facing change from the original PR) ### How was this patch tested? Unittest was changed (in order for us to detect that source compatibility easily). Closes apache#27756 from HyukjinKwon/SPARK-25202. Authored-by: HyukjinKwon <[email protected]> Signed-off-by: HyukjinKwon <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
To address the concern pointed out in #22227. This will make
splitsource-compatible by removing minimal cosmetic changes.Why are the changes needed?
For source compatibility.
Does this PR introduce any user-facing change?
No (it will prevent potential user-facing change from the original PR)
How was this patch tested?
Unittest was changed (in order for us to detect that source compatibility easily).