[SPARK-30881][SQL][DOCS]Revise the doc of spark.sql.sources.parallelPartitionDiscovery.threshold#27639
Closed
gengliangwang wants to merge 1 commit intoapache:masterfrom
Closed
Conversation
gengliangwang
commented
Feb 19, 2020
| "files with another Spark distributed job. This applies to Parquet, ORC, CSV, JSON and " + | ||
| "LibSVM data sources.") | ||
| "files with another Spark distributed job. This configuration is effective only when " + | ||
| "using file-based sources such as Parquet, JSON and ORC.") |
Member
Author
There was a problem hiding this comment.
This follows the doc of spark.sql.files.maxPartitionBytes and spark.sql.files.openCostInBytes
|
Test build #118685 has finished for PR 27639 at commit
|
Member
Author
|
retest this please. |
|
Test build #118686 has finished for PR 27639 at commit
|
maropu
changed the title
Member
|
retest this please |
|
Test build #118687 has finished for PR 27639 at commit
|
Member
Author
Member
|
Ah, I see... |
Member
Author
|
retest this please. |
cloud-fan
approved these changes
Feb 20, 2020
maropu
approved these changes
Feb 20, 2020
|
Test build #118696 has finished for PR 27639 at commit
|
Contributor
|
retest this please |
Member
Author
|
Thanks for the review. |
gengliangwang
added a commit
that referenced
this pull request
Feb 20, 2020
…PartitionDiscovery.threshold ### What changes were proposed in this pull request? Revise the doc of SQL configuration `spark.sql.sources.parallelPartitionDiscovery.threshold`. ### Why are the changes needed? The doc of configuration "spark.sql.sources.parallelPartitionDiscovery.threshold" is not accurate on the part "This applies to Parquet, ORC, CSV, JSON and LibSVM data sources". We should revise it as effective on all the file-based data sources. ### Does this PR introduce any user-facing change? No ### How was this patch tested? None. It's just doc. Closes #27639 from gengliangwang/reviseParallelPartitionDiscovery. Authored-by: Gengliang Wang <gengliang.wang@databricks.com> Signed-off-by: Gengliang Wang <gengliang.wang@databricks.com> (cherry picked from commit 92d5d40) Signed-off-by: Gengliang Wang <gengliang.wang@databricks.com>
|
Test build #118705 has finished for PR 27639 at commit
|
sjincho
pushed a commit
to sjincho/spark
that referenced
this pull request
Apr 15, 2020
…PartitionDiscovery.threshold ### What changes were proposed in this pull request? Revise the doc of SQL configuration `spark.sql.sources.parallelPartitionDiscovery.threshold`. ### Why are the changes needed? The doc of configuration "spark.sql.sources.parallelPartitionDiscovery.threshold" is not accurate on the part "This applies to Parquet, ORC, CSV, JSON and LibSVM data sources". We should revise it as effective on all the file-based data sources. ### Does this PR introduce any user-facing change? No ### How was this patch tested? None. It's just doc. Closes apache#27639 from gengliangwang/reviseParallelPartitionDiscovery. Authored-by: Gengliang Wang <gengliang.wang@databricks.com> Signed-off-by: Gengliang Wang <gengliang.wang@databricks.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Revise the doc of SQL configuration
spark.sql.sources.parallelPartitionDiscovery.threshold.Why are the changes needed?
The doc of configuration "spark.sql.sources.parallelPartitionDiscovery.threshold" is not accurate on the part "This applies to Parquet, ORC, CSV, JSON and LibSVM data sources".
We should revise it as effective on all the file-based data sources.
Does this PR introduce any user-facing change?
No
How was this patch tested?
None. It's just doc.