[GRAPHX] [MINOR] Fix typo setRest => setDest#27594
Closed
xwu-intel wants to merge 1 commit intoapache:masterfrom
Closed
[GRAPHX] [MINOR] Fix typo setRest => setDest#27594xwu-intel wants to merge 1 commit intoapache:masterfrom
xwu-intel wants to merge 1 commit intoapache:masterfrom
Conversation
Member
|
ok to test |
Member
|
Since this fix is trivial, it looks fine to me if the tests passed. cc: @srowen |
|
Test build #118494 has finished for PR 27594 at commit
|
Member
|
Yep, fine. It's an internal method. |
Member
|
Merged to master |
sjincho
pushed a commit
to sjincho/spark
that referenced
this pull request
Apr 15, 2020
### What changes were proposed in this pull request? Fix typo def setRest(dstId: VertexId, localDstId: Int, dstAttr: VD, attr: ED) to def setDest(dstId: VertexId, localDstId: Int, dstAttr: VD, attr: ED) ### Why are the changes needed? Typo ### Does this PR introduce any user-facing change? No ### How was this patch tested? N/A Closes apache#27594 from xwu99/fix-graphx-setDest. Authored-by: Wu, Xiaochang <xiaochang.wu@intel.com> Signed-off-by: Sean Owen <srowen@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Fix typo
def setRest(dstId: VertexId, localDstId: Int, dstAttr: VD, attr: ED)
to
def setDest(dstId: VertexId, localDstId: Int, dstAttr: VD, attr: ED)
Why are the changes needed?
Typo
Does this PR introduce any user-facing change?
No
How was this patch tested?
N/A