Skip to content

Comments

[SPARK-30691][SQL][DOC][FOLLOW-UP] Make link names exactly the same as the side bar names#27591

Closed
huaxingao wants to merge 1 commit intoapache:masterfrom
huaxingao:spark-doc-followup
Closed

[SPARK-30691][SQL][DOC][FOLLOW-UP] Make link names exactly the same as the side bar names#27591
huaxingao wants to merge 1 commit intoapache:masterfrom
huaxingao:spark-doc-followup

Conversation

@huaxingao
Copy link
Contributor

What changes were proposed in this pull request?

Make link names exactly the same as the side bar names

Why are the changes needed?

Make doc look better

Does this PR introduce any user-facing change?

before:

image

after:

image

How was this patch tested?

Manually build and check the docs

@huaxingao
Copy link
Contributor Author

cc @gatorsmile @srowen

@SparkQA
Copy link

SparkQA commented Feb 15, 2020

Test build #118457 has finished for PR 27591 at commit de8dcb9.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@srowen srowen closed this in 0a03e7e Feb 16, 2020
srowen pushed a commit that referenced this pull request Feb 16, 2020
…s the side bar names

### What changes were proposed in this pull request?
Make link names exactly the same as the side bar names

### Why are the changes needed?
Make doc look better

### Does this PR introduce any user-facing change?
before:

![image](https://user-images.githubusercontent.com/13592258/74578603-ad300100-4f4a-11ea-8430-11fccf31eab4.png)

after:

![image](https://user-images.githubusercontent.com/13592258/74578670-eff1d900-4f4a-11ea-97d8-5908c0e50e95.png)

### How was this patch tested?
Manually build and check the docs

Closes #27591 from huaxingao/spark-doc-followup.

Authored-by: Huaxin Gao <huaxing@us.ibm.com>
Signed-off-by: Sean Owen <srowen@gmail.com>
(cherry picked from commit 0a03e7e)
Signed-off-by: Sean Owen <srowen@gmail.com>
@srowen
Copy link
Member

srowen commented Feb 16, 2020

Merged to master/3.0

@huaxingao
Copy link
Contributor Author

Thank you! @srowen @kiszk

@huaxingao huaxingao deleted the spark-doc-followup branch February 20, 2020 23:50
sjincho pushed a commit to sjincho/spark that referenced this pull request Apr 15, 2020
…s the side bar names

### What changes were proposed in this pull request?
Make link names exactly the same as the side bar names

### Why are the changes needed?
Make doc look better

### Does this PR introduce any user-facing change?
before:

![image](https://user-images.githubusercontent.com/13592258/74578603-ad300100-4f4a-11ea-8430-11fccf31eab4.png)

after:

![image](https://user-images.githubusercontent.com/13592258/74578670-eff1d900-4f4a-11ea-97d8-5908c0e50e95.png)

### How was this patch tested?
Manually build and check the docs

Closes apache#27591 from huaxingao/spark-doc-followup.

Authored-by: Huaxin Gao <huaxing@us.ibm.com>
Signed-off-by: Sean Owen <srowen@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants