[SPARK-30814][SQL] ALTER TABLE ... ADD COLUMN position should be able to reference columns being added #27584
Closed
imback82 wants to merge 5 commits intoapache:masterfrom
Closed
[SPARK-30814][SQL] ALTER TABLE ... ADD COLUMN position should be able to reference columns being added #27584imback82 wants to merge 5 commits intoapache:masterfrom
imback82 wants to merge 5 commits intoapache:masterfrom
Conversation
Contributor
Author
|
Test build #118443 has finished for PR 27584 at commit
|
|
Test build #118451 has finished for PR 27584 at commit
|
cloud-fan
reviewed
Feb 17, 2020
| def apply(plan: LogicalPlan): LogicalPlan = plan.resolveOperatorsUp { | ||
| case a @ AlterTable(_, _, t: NamedRelation, changes) if t.resolved => | ||
| // Keeps track of new columns being added. Keys are normalized parent names and | ||
| // values are field names that belong to their parent. |
Contributor
There was a problem hiding this comment.
Can we be more clear here? For example, if we add a column a.b.c.d, which part should be the key? a.b.c or a.b?
cloud-fan
reviewed
Feb 17, 2020
| case after: After => | ||
| // Handle the case where column position is referencing new columns being added. | ||
| if (!colsToAdd.contains(add.fieldNames().init :+ after.column)) { | ||
| positionArgumentExists(add.position(), parent) |
Contributor
There was a problem hiding this comment.
shall we just add one more parameter to positionArgumentExists for the newly added columns?
Contributor
There was a problem hiding this comment.
just want to make sure all the caller side of positionArgumentExists take care of newly added columns.
cloud-fan
approved these changes
Feb 17, 2020
Contributor
cloud-fan
left a comment
cloud-fan
left a comment
There was a problem hiding this comment.
LGTM except one comment
|
Test build #118544 has finished for PR 27584 at commit
|
Contributor
|
retest this please |
|
Test build #118556 has finished for PR 27584 at commit
|
Contributor
|
LGTM as well! Thanks @imback82 for the quick fix :) |
|
Test build #118599 has finished for PR 27584 at commit
|
Contributor
|
thanks, merging to master/3.0! |
cloud-fan
pushed a commit
that referenced
this pull request
Feb 19, 2020
… able to reference columns being added (Backport of #27584 + partial #27482) ### What changes were proposed in this pull request? In ALTER TABLE, a column in ADD COLUMNS can depend on the position of a column that is just being added. For example, for a table with the following schema: ``` root: - a: string - b: long ``` , the following should work: ``` ALTER TABLE t ADD COLUMNS (x int AFTER a, y int AFTER x) ``` Currently, the above statement will throw an exception saying that AFTER x cannot be resolved, because x doesn't exist yet. This PR proposes to fix this issue. ### Why are the changes needed? To fix a bug described above. ### Does this PR introduce any user-facing change? Yes, now ``` ALTER TABLE t ADD COLUMNS (x int AFTER a, y int AFTER x) ``` works as expected. ### How was this patch tested? Added new tests Closes #27624 from imback82/backport_27584. Authored-by: Terry Kim <yuminkim@gmail.com> Signed-off-by: Wenchen Fan <wenchen@databricks.com>
sjincho
pushed a commit
to sjincho/spark
that referenced
this pull request
Apr 15, 2020
… to reference columns being added ### What changes were proposed in this pull request? In ALTER TABLE, a column in ADD COLUMNS can depend on the position of a column that is just being added. For example, for a table with the following schema: ``` root: - a: string - b: long ``` , the following should work: ``` ALTER TABLE t ADD COLUMNS (x int AFTER a, y int AFTER x) ``` Currently, the above statement will throw an exception saying that AFTER x cannot be resolved, because x doesn't exist yet. This PR proposes to fix this issue. ### Why are the changes needed? To fix a bug described above. ### Does this PR introduce any user-facing change? Yes, now ``` ALTER TABLE t ADD COLUMNS (x int AFTER a, y int AFTER x) ``` works as expected. ### How was this patch tested? Added new tests Closes apache#27584 from imback82/alter_table_pos_fix. Authored-by: Terry Kim <yuminkim@gmail.com> Signed-off-by: Wenchen Fan <wenchen@databricks.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
In ALTER TABLE, a column in ADD COLUMNS can depend on the position of a column that is just being added. For example, for a table with the following schema:
, the following should work:
Currently, the above statement will throw an exception saying that AFTER x cannot be resolved, because x doesn't exist yet. This PR proposes to fix this issue.
Why are the changes needed?
To fix a bug described above.
Does this PR introduce any user-facing change?
Yes, now
works as expected.
How was this patch tested?
Added new tests