Skip to content

Comments

[SPARK-30807][K8S][TESTS] Support Java 11 in K8S integration tests#27559

Closed
dongjoon-hyun wants to merge 2 commits intoapache:masterfrom
dongjoon-hyun:SPARK-30807
Closed

[SPARK-30807][K8S][TESTS] Support Java 11 in K8S integration tests#27559
dongjoon-hyun wants to merge 2 commits intoapache:masterfrom
dongjoon-hyun:SPARK-30807

Conversation

@dongjoon-hyun
Copy link
Member

@dongjoon-hyun dongjoon-hyun commented Feb 13, 2020

What changes were proposed in this pull request?

This PR aims to support JDK11 test in K8S integration tests.

  • This is an update in testing framework instead of individual tests.
  • This will enable JDK11 runtime test when you didn't installed JDK11 on your local system.

Why are the changes needed?

Apache Spark 3.0.0 adds JDK11 support, but K8s integration tests use JDK8 until now.

Does this PR introduce any user-facing change?

No. This is a dev-only test-related PR.

How was this patch tested?

This is irrelevant to Jenkins UT, but Jenkins K8S IT (JDK8) should pass.

And, manually do the following for JDK11 test.

$ NO_MANUAL=1 ./dev/make-distribution.sh --r --pip --tgz -Phadoop-3.2 -Pkubernetes
$ resource-managers/kubernetes/integration-tests/dev/dev-run-integration-tests.sh --java-image-tag 11-jre-slim --spark-tgz $PWD/spark-*.tgz
$ docker run -it --rm kubespark/spark:1318DD8A-2B15-4A00-BC69-D0E90CED235B /usr/local/openjdk-11/bin/java --version | tail -n1
OpenJDK 64-Bit Server VM 18.9 (build 11.0.6+10, mixed mode)

@dongjoon-hyun dongjoon-hyun changed the title [SPARK-30807][K8S][TEST] Support JDK11 in K8S integration tests [SPARK-30807][K8S][TEST] Support Java 11 in K8S integration tests Feb 13, 2020
@dongjoon-hyun dongjoon-hyun changed the title [SPARK-30807][K8S][TEST] Support Java 11 in K8S integration tests [SPARK-30807][K8S][TESTS] Support Java 11 in K8S integration tests Feb 13, 2020
@SparkQA
Copy link

SparkQA commented Feb 13, 2020

Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/23101/

@SparkQA
Copy link

SparkQA commented Feb 13, 2020

Kubernetes integration test status failure
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/23101/

@SparkQA
Copy link

SparkQA commented Feb 13, 2020

Test build #118344 has finished for PR 27559 at commit 927ff4a.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@dongjoon-hyun dongjoon-hyun changed the title [SPARK-30807][K8S][TESTS] Support Java 11 in K8S integration tests [WIP][SPARK-30807][K8S][TESTS] Support Java 11 in K8S integration tests Feb 13, 2020
@SparkQA
Copy link

SparkQA commented Feb 13, 2020

Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/23132/

@dongjoon-hyun dongjoon-hyun changed the title [WIP][SPARK-30807][K8S][TESTS] Support Java 11 in K8S integration tests [SPARK-30807][K8S][TESTS] Support Java 11 in K8S integration tests Feb 13, 2020
@SparkQA
Copy link

SparkQA commented Feb 13, 2020

Kubernetes integration test status success
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/23132/

@dongjoon-hyun
Copy link
Member Author

Hi, @liyinan926 .
Could you review this PR?

Copy link
Contributor

@liyinan926 liyinan926 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@dongjoon-hyun
Copy link
Member Author

Thank you so much, @liyinan926 !

@dongjoon-hyun
Copy link
Member Author

Since this is irrelevant to UT, I'll merge this to master/branch-3.0.

dongjoon-hyun added a commit that referenced this pull request Feb 13, 2020
### What changes were proposed in this pull request?

This PR aims to support JDK11 test in K8S integration tests.
- This is an update in testing framework instead of individual tests.
- This will enable JDK11 runtime test when you didn't installed JDK11 on your local system.

### Why are the changes needed?

Apache Spark 3.0.0 adds JDK11 support, but K8s integration tests use JDK8 until now.

### Does this PR introduce any user-facing change?

No. This is a dev-only test-related PR.

### How was this patch tested?

This is irrelevant to Jenkins UT, but Jenkins K8S IT (JDK8) should pass.
- #27559 (comment) (JDK8 Passed)

And, manually do the following for JDK11 test.
```
$ NO_MANUAL=1 ./dev/make-distribution.sh --r --pip --tgz -Phadoop-3.2 -Pkubernetes
$ resource-managers/kubernetes/integration-tests/dev/dev-run-integration-tests.sh --java-image-tag 11-jre-slim --spark-tgz $PWD/spark-*.tgz
```

```
$ docker run -it --rm kubespark/spark:1318DD8A-2B15-4A00-BC69-D0E90CED235B /usr/local/openjdk-11/bin/java --version | tail -n1
OpenJDK 64-Bit Server VM 18.9 (build 11.0.6+10, mixed mode)
```

Closes #27559 from dongjoon-hyun/SPARK-30807.

Authored-by: Dongjoon Hyun <dhyun@apple.com>
Signed-off-by: Dongjoon Hyun <dhyun@apple.com>
(cherry picked from commit 8596991)
Signed-off-by: Dongjoon Hyun <dhyun@apple.com>
@dongjoon-hyun dongjoon-hyun deleted the SPARK-30807 branch February 13, 2020 19:18
@SparkQA
Copy link

SparkQA commented Feb 13, 2020

Test build #118375 has finished for PR 27559 at commit 73cddd9.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

sjincho pushed a commit to sjincho/spark that referenced this pull request Apr 15, 2020
### What changes were proposed in this pull request?

This PR aims to support JDK11 test in K8S integration tests.
- This is an update in testing framework instead of individual tests.
- This will enable JDK11 runtime test when you didn't installed JDK11 on your local system.

### Why are the changes needed?

Apache Spark 3.0.0 adds JDK11 support, but K8s integration tests use JDK8 until now.

### Does this PR introduce any user-facing change?

No. This is a dev-only test-related PR.

### How was this patch tested?

This is irrelevant to Jenkins UT, but Jenkins K8S IT (JDK8) should pass.
- apache#27559 (comment) (JDK8 Passed)

And, manually do the following for JDK11 test.
```
$ NO_MANUAL=1 ./dev/make-distribution.sh --r --pip --tgz -Phadoop-3.2 -Pkubernetes
$ resource-managers/kubernetes/integration-tests/dev/dev-run-integration-tests.sh --java-image-tag 11-jre-slim --spark-tgz $PWD/spark-*.tgz
```

```
$ docker run -it --rm kubespark/spark:1318DD8A-2B15-4A00-BC69-D0E90CED235B /usr/local/openjdk-11/bin/java --version | tail -n1
OpenJDK 64-Bit Server VM 18.9 (build 11.0.6+10, mixed mode)
```

Closes apache#27559 from dongjoon-hyun/SPARK-30807.

Authored-by: Dongjoon Hyun <dhyun@apple.com>
Signed-off-by: Dongjoon Hyun <dhyun@apple.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants