Revert "[SPARK-29721][SQL] Prune unnecessary nested fields from Generate without Project #27504
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ate without Project" This reverts commit a0e63b6.
viirya
changed the title
Member
Author
|
cc @gatorsmile |
|
Test build #118088 has finished for PR 27504 at commit
|
Member
Author
|
retest this please |
|
Test build #118093 has finished for PR 27504 at commit
|
gatorsmile
approved these changes
Feb 10, 2020
Member
gatorsmile
left a comment
gatorsmile
left a comment
There was a problem hiding this comment.
LGTM
Thanks for your work!
Member
|
Late LGTM. |
Member
|
And 'branch-3.0'? |
Member
|
Hi, @gatorsmile . When you reopen this JIRA issue, please remove |
Member
|
I'll backport this to |
dongjoon-hyun
pushed a commit
that referenced
this pull request
Feb 10, 2020
…ate without Project This reverts commit a0e63b6. ### What changes were proposed in this pull request? This reverts the patch at #26978 based on gatorsmile's suggestion. ### Why are the changes needed? Original patch #26978 has not considered a corner case. We may need to put more time on ensuring we can cover all cases. ### Does this PR introduce any user-facing change? No ### How was this patch tested? Unit test. Closes #27504 from viirya/revert-SPARK-29721. Authored-by: Liang-Chi Hsieh <[email protected]> Signed-off-by: Xiao Li <[email protected]>
sjincho
pushed a commit
to sjincho/spark
that referenced
this pull request
Apr 15, 2020
…ate without Project This reverts commit a0e63b6. ### What changes were proposed in this pull request? This reverts the patch at apache#26978 based on gatorsmile's suggestion. ### Why are the changes needed? Original patch apache#26978 has not considered a corner case. We may need to put more time on ensuring we can cover all cases. ### Does this PR introduce any user-facing change? No ### How was this patch tested? Unit test. Closes apache#27504 from viirya/revert-SPARK-29721. Authored-by: Liang-Chi Hsieh <[email protected]> Signed-off-by: Xiao Li <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reverts commit a0e63b6.
What changes were proposed in this pull request?
This reverts the patch at #26978 based on @gatorsmile's suggestion.
Why are the changes needed?
Original patch #26978 has not considered a corner case. We may need to put more time on ensuring we can cover all cases.
Does this PR introduce any user-facing change?
No
How was this patch tested?
Unit test.