Skip to content

[SPARK-30759][SQL] Initialize cache for foldable patterns in StringRegexExpression #27502

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
MaxGekk wants to merge 3 commits into from
Closed

[SPARK-30759][SQL] Initialize cache for foldable patterns in StringRegexExpression #27502

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
b2cbe32
Fix cache initialization for foldable expressions
MaxGekk Feb 8, 2020
0986e5c
Fix comment
MaxGekk Feb 8, 2020
7bc5d9e
Avoid unnecessary changes
MaxGekk Feb 10, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions ...catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/regexpExpressions.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,9 +41,10 @@ trait StringRegexExpression extends Expression

override def dataType: DataType = BooleanType

// try cache the pattern for Literal
// try cache foldable pattern
private lazy val cache: Pattern = pattern match {
case Literal(value: String, StringType) => compile(value)
Copy link
Member

@dongjoon-hyun dongjoon-hyun Feb 8, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@MaxGekk . This is SPARK-9242 (Spark 1.5.0) https://github.com/apache/spark/pull/8321/files#diff-39298b470865a4cbc67398a4ea11e767R41.

Copy link
Member Author

@MaxGekk MaxGekk Feb 9, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reynold just moved the code. Actually it exists since 1.0.0: af3746c#diff-d788f93e29b4d25cdd7d60328587678bR42

case p: Expression if p.foldable =>
Copy link
Member

@dongjoon-hyun dongjoon-hyun Feb 8, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This will consider 'a' + 'b' from now. I prefer to consider SPARK-30759 as a performance improvement and merge to master only.

Copy link
Member Author

@MaxGekk MaxGekk Feb 9, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The changes don't impact on behavior in any case, so, they can be considered only as an optimization.

compile(p.eval().asInstanceOf[UTF8String].toString)
case _ => null
}

Expand Down