Skip to content

Conversation

@zhengruifeng
Copy link
Contributor

What changes were proposed in this pull request?

Revert
#27360
#27396
#27374
#27389

Why are the changes needed?

BLAS need more performace tests, specially on sparse datasets

Does this PR introduce any user-facing change?

remove newly added param blockSize

How was this patch tested?

reverted testsuites

@HyukjinKwon
Copy link
Member

BTW @zhengruifeng, it might be better to revert the commits (a69f8ef, 2b27c0a, c148fae and 6612bb4) one by one manually for trackability once the tests pass and this PR is approved.

@zhengruifeng zhengruifeng reopened this Feb 7, 2020
@zhengruifeng
Copy link
Contributor Author

@HyukjinKwon OK, I will reopen a PR to test each revert commit. Thanks!

@SparkQA
Copy link

SparkQA commented Feb 7, 2020

Test build #118013 has finished for PR 27486 at commit 6612bb4.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@zhengruifeng zhengruifeng deleted the revert_blockify branch February 7, 2020 11:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants