-
Notifications
You must be signed in to change notification settings - Fork 29k
[SPARK-3892][SQL] remove redundant type name #2747
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Can one of the admins verify this patch? |
|
QA tests have started for PR 2747 at commit
|
|
QA tests have finished for PR 2747 at commit
|
|
Test PASSed. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I tend to just remove this method since it's not used anywhere. Another important reason is that the DataType class hierarchy is now part of the public API, which should be minimized for safe :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
To be honest, this method is there totally because I forgot to remove it... Otherwise at least object ArrayType and object StructType should have their own versions of typeName.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actually they do have... should I remove them?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yea, please go ahead :)
|
QA tests have started for PR 2747 at commit
|
|
QA tests have finished for PR 2747 at commit
|
|
Test PASSed. |
|
This LGTM. Please rename the PR title to reflect the actual changes. |
|
Thanks! Merged to master. |
No description provided.