[SPARK-30310][CORE][2.4] Resolve missing match case in SparkUncaughtExceptionHandler and added tests #27384
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ionHandler and added tests 1) Added missing match case to SparkUncaughtExceptionHandler, so that it would not halt the process when the exception doesn't match any of the match case statements. 2) Added log message before halting process. During debugging it wasn't obvious why the Worker process would DEAD (until we set SPARK_NO_DAEMONIZE=1) due to the shell-scripts puts the process into background and essentially absorbs the exit code. 3) Added SparkUncaughtExceptionHandlerSuite. Basically we create a Spark exception-throwing application with SparkUncaughtExceptionHandler and then check its exit code. SPARK-30310, because the process would halt unexpectedly. All unit tests (mvn test) were ran and OK. Closes #26955 from tinhto-000/uncaught_exception_fix. Authored-by: Tin Hang To <[email protected]> Signed-off-by: Sean Owen <[email protected]>
dongjoon-hyun
changed the title
Member
|
ok to test |
|
Test build #117520 has finished for PR 27384 at commit
|
dongjoon-hyun
approved these changes
Jan 29, 2020
Member
dongjoon-hyun
left a comment
dongjoon-hyun
left a comment
There was a problem hiding this comment.
+1, LGTM. Thank you, @n-marion .
Merged to branch-2.4.
dongjoon-hyun
pushed a commit
that referenced
this pull request
Jan 29, 2020
…xceptionHandler and added tests ### What changes were proposed in this pull request? Backport of SPARK-30310 from master (f5f05d5) 1) Added missing match case to SparkUncaughtExceptionHandler, so that it would not halt the process when the exception doesn't match any of the match case statements. 2) Added log message before halting process. During debugging it wasn't obvious why the Worker process would DEAD (until we set SPARK_NO_DAEMONIZE=1) due to the shell-scripts puts the process into background and essentially absorbs the exit code. 3) Added SparkUncaughtExceptionHandlerSuite. Basically we create a Spark exception-throwing application with SparkUncaughtExceptionHandler and then check its exit code. ### Why are the changes needed? SPARK-30310, because the process would halt unexpectedly. ### How was this patch tested? All unit tests (mvn test) were ran and OK. Closes #27384 from n-marion/branch-2.4_30310-backport. Authored-by: git <[email protected]> Signed-off-by: Dongjoon Hyun <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Backport of SPARK-30310 from master (f5f05d5)
Why are the changes needed?
SPARK-30310, because the process would halt unexpectedly.
How was this patch tested?
All unit tests (mvn test) were ran and OK.