Skip to content

Conversation

@nchammas
Copy link
Contributor

@nchammas nchammas commented Jan 28, 2020

What changes were proposed in this pull request?

This PR removes any dependencies on pypandoc. It also makes related tweaks to the docs README to clarify the dependency on pandoc (not pypandoc).

Why are the changes needed?

We are using pypandoc to convert the Spark README from Markdown to ReST for PyPI. PyPI now natively supports Markdown, so we don't need pypandoc anymore. The dependency on pypandoc also sometimes causes issues when installing Python packages that depend on PySpark, as described in #18981.

Does this PR introduce any user-facing change?

No.

How was this patch tested?

Manually:

python -m venv venv
source venv/bin/activate
pip install -U pip

cd python/
python setup.py sdist
pip install dist/pyspark-3.0.0.dev0.tar.gz 
pyspark --version

I also built the PySpark and R API docs with jekyll and reviewed them locally.

It would be good if a maintainer could also test this by creating a PySpark distribution and uploading it to Test PyPI to confirm the README looks as it should.

@nchammas
Copy link
Contributor Author

cc @holdenk

@SparkQA
Copy link

SparkQA commented Jan 28, 2020

Test build #117496 has finished for PR 27376 at commit 4098acf.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@dongjoon-hyun dongjoon-hyun changed the title [SPARK-30665] Remove Pandoc dependency in PySpark setup.py [SPARK-30665][PYSPARK] Remove Pandoc dependency in PySpark setup.py Jan 28, 2020
@dongjoon-hyun
Copy link
Member

Oh, thank you for making a PR for this, @nchammas . pandoc bites us frequently.

@dongjoon-hyun
Copy link
Member

cc @HyukjinKwon

@SparkQA
Copy link

SparkQA commented Jan 29, 2020

Test build #117515 has finished for PR 27376 at commit 16d42c3.

  • This patch passes all tests.
  • This patch does not merge cleanly.
  • This patch adds no public classes.

@SparkQA
Copy link

SparkQA commented Jan 29, 2020

Test build #117518 has finished for PR 27376 at commit 70f3b88.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@dongjoon-hyun
Copy link
Member

BTW, this improvement should not go to branch-2.4. I updated Affected Version in JIRA, @nchammas .

Copy link
Member

@HyukjinKwon HyukjinKwon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@nchammas nchammas changed the title [SPARK-30665][PYSPARK] Remove Pandoc dependency in PySpark setup.py [SPARK-30665][PYSPARK] Eliminate pypandoc dependency Jan 30, 2020
Copy link
Member

@HyukjinKwon HyukjinKwon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@HyukjinKwon HyukjinKwon changed the title [SPARK-30665][PYSPARK] Eliminate pypandoc dependency [SPARK-30665][DOCS][PYTHON] Eliminate pypandoc dependency Jan 30, 2020
@HyukjinKwon
Copy link
Member

@nchammas, mind updating the PR description accordingly as well?

@nchammas
Copy link
Contributor Author

Updated the description. Also made some tweaks to the docs README to separate R prerequisites from general API doc prerequisites. Happy to make any further changes if necessary.

@HyukjinKwon HyukjinKwon changed the title [SPARK-30665][DOCS][PYTHON] Eliminate pypandoc dependency [SPARK-30665][DOCS][BUILD][PYTHON] Eliminate pypandoc dependency Jan 30, 2020
@SparkQA
Copy link

SparkQA commented Jan 30, 2020

Test build #117533 has finished for PR 27376 at commit 6fa5b8c.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@SparkQA
Copy link

SparkQA commented Jan 30, 2020

Test build #117540 has finished for PR 27376 at commit 71182fe.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@HyukjinKwon
Copy link
Member

Merged to master.

@SparkQA
Copy link

SparkQA commented Jan 30, 2020

Test build #117542 has finished for PR 27376 at commit 98e0a31.

  • This patch fails due to an unknown error code, -9.
  • This patch merges cleanly.
  • This patch adds no public classes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants