-
Notifications
You must be signed in to change notification settings - Fork 29k
[SPARK-30665][DOCS][BUILD][PYTHON] Eliminate pypandoc dependency #27376
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
cc @holdenk |
|
Test build #117496 has finished for PR 27376 at commit
|
|
Oh, thank you for making a PR for this, @nchammas . |
|
cc @HyukjinKwon |
|
Test build #117515 has finished for PR 27376 at commit
|
|
Test build #117518 has finished for PR 27376 at commit
|
|
BTW, this improvement should not go to |
HyukjinKwon
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
HyukjinKwon
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
|
@nchammas, mind updating the PR description accordingly as well? |
|
Updated the description. Also made some tweaks to the docs README to separate R prerequisites from general API doc prerequisites. Happy to make any further changes if necessary. |
|
Test build #117533 has finished for PR 27376 at commit
|
|
Test build #117540 has finished for PR 27376 at commit
|
|
Merged to master. |
|
Test build #117542 has finished for PR 27376 at commit
|
What changes were proposed in this pull request?
This PR removes any dependencies on pypandoc. It also makes related tweaks to the docs README to clarify the dependency on pandoc (not pypandoc).
Why are the changes needed?
We are using pypandoc to convert the Spark README from Markdown to ReST for PyPI. PyPI now natively supports Markdown, so we don't need pypandoc anymore. The dependency on pypandoc also sometimes causes issues when installing Python packages that depend on PySpark, as described in #18981.
Does this PR introduce any user-facing change?
No.
How was this patch tested?
Manually:
I also built the PySpark and R API docs with
jekylland reviewed them locally.It would be good if a maintainer could also test this by creating a PySpark distribution and uploading it to Test PyPI to confirm the README looks as it should.