Skip to content

[SPARK-30535][SQL][FOLLOWUP] Update error message for ALTER TABLE when table is resolved to temp view #27315

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
imback82 wants to merge 1 commit into from
Closed

[SPARK-30535][SQL][FOLLOWUP] Update error message for ALTER TABLE when table is resolved to temp view #27315

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/CheckAnalysis.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -93,7 +93,7 @@ trait CheckAnalysis extends PredicateHelper {

case alter: AlterTable =>
alter.table match {
case u @ UnresolvedTableWithViewExists(view) if !view.isTempView =>
case u @ UnresolvedTableWithViewExists(view) =>
u.failAnalysis("Cannot alter a view with ALTER TABLE. Please use ALTER VIEW instead")
case _ =>
}
Expand Down
4 changes: 2 additions & 2 deletions sql/core/src/test/resources/sql-tests/results/change-column.sql.out
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -195,7 +195,7 @@ ALTER TABLE temp_view CHANGE a TYPE INT COMMENT 'this is column a'
struct<>
-- !query 20 output
org.apache.spark.sql.AnalysisException
temp_view is a temp view not a table.; line 1 pos 0
Cannot alter a view with ALTER TABLE. Please use ALTER VIEW instead; line 1 pos 0
Copy link
Member

@dongjoon-hyun dongjoon-hyun Jan 22, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi, @cloud-fan and @imback82
Cannot alter a view with ALTER TABLE. looks okay, but Please use ALTER VIEW instead looks like we mislead the users to try ALTER VIEW temp_view CHANGE a TYPE INT COMMENT 'this is column a'.

Copy link
Member

@dongjoon-hyun dongjoon-hyun Jan 22, 2020 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The other changes in this PR are the same. The directional message parts look misleading.

Copy link
Contributor

@cloud-fan cloud-fan Jan 22, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a good point. How about just Cannot alter a temp view with ALTER TABLE. as the error message?

Copy link
Member

@dongjoon-hyun dongjoon-hyun Jan 22, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1 for @cloud-fan 's advice.



-- !query 21
Expand All @@ -212,7 +212,7 @@ ALTER TABLE global_temp.global_temp_view CHANGE a TYPE INT COMMENT 'this is colu
struct<>
-- !query 22 output
org.apache.spark.sql.AnalysisException
global_temp.global_temp_view is a temp view not a table.; line 1 pos 0
Cannot alter a view with ALTER TABLE. Please use ALTER VIEW instead; line 1 pos 0


-- !query 23
Expand Down
4 changes: 2 additions & 2 deletions sql/core/src/test/scala/org/apache/spark/sql/execution/SQLViewSuite.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -145,13 +145,13 @@ abstract class SQLViewSuite extends QueryTest with SQLTestUtils {
// For v2 ALTER TABLE statements, we have better error message saying view is not supported.
assertAnalysisError(
s"ALTER TABLE $viewName SET LOCATION '/path/to/your/lovely/heart'",
s"$viewName is a temp view not a table")
"Cannot alter a view with ALTER TABLE. Please use ALTER VIEW instead")

// For the following v2 ALERT TABLE statements, relations are first resolved before
// unsupported operations are checked.
assertAnalysisError(
s"ALTER TABLE $viewName PARTITION (a='4') SET LOCATION '/path/to/home'",
s"$viewName is a temp view not a table")
"Cannot alter a view with ALTER TABLE. Please use ALTER VIEW instead")
}
}

Expand Down
3 changes: 2 additions & 1 deletion sql/core/src/test/scala/org/apache/spark/sql/execution/command/DDLSuite.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2779,7 +2779,8 @@ abstract class DDLSuite extends QueryTest with SQLTestUtils {
val e = intercept[AnalysisException] {
sql("ALTER TABLE tmp_v ADD COLUMNS (c3 INT)")
}
assert(e.message.contains("tmp_v is a temp view not a table"))
assert(
e.message.contains("Cannot alter a view with ALTER TABLE. Please use ALTER VIEW instead"))
}
}

Expand Down