Skip to content

[Minor] use norm operator after breeze 0.10 upgrade #2730

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
witgo wants to merge 1 commit into from
Closed

[Minor] use norm operator after breeze 0.10 upgrade #2730

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 10 additions & 8 deletions mllib/src/test/scala/org/apache/spark/mllib/feature/NormalizerSuite.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,6 +19,8 @@ package org.apache.spark.mllib.feature

import org.scalatest.FunSuite

import breeze.linalg.{norm => brzNorm}

import org.apache.spark.mllib.linalg.{DenseVector, SparseVector, Vectors}
import org.apache.spark.mllib.util.LocalSparkContext
import org.apache.spark.mllib.util.TestingUtils._
Expand Down Expand Up @@ -50,10 +52,10 @@ class NormalizerSuite extends FunSuite with LocalSparkContext {

assert((data1, data1RDD.collect()).zipped.forall((v1, v2) => v1 ~== v2 absTol 1E-5))

assert(data1(0).toBreeze.norm(1) ~== 1.0 absTol 1E-5)
assert(data1(2).toBreeze.norm(1) ~== 1.0 absTol 1E-5)
assert(data1(3).toBreeze.norm(1) ~== 1.0 absTol 1E-5)
assert(data1(4).toBreeze.norm(1) ~== 1.0 absTol 1E-5)
assert(brzNorm(data1(0).toBreeze, 1) ~== 1.0 absTol 1E-5)
assert(brzNorm(data1(2).toBreeze, 1) ~== 1.0 absTol 1E-5)
assert(brzNorm(data1(3).toBreeze, 1) ~== 1.0 absTol 1E-5)
assert(brzNorm(data1(4).toBreeze, 1) ~== 1.0 absTol 1E-5)

assert(data1(0) ~== Vectors.sparse(3, Seq((0, -0.465116279), (1, 0.53488372))) absTol 1E-5)
assert(data1(1) ~== Vectors.dense(0.0, 0.0, 0.0) absTol 1E-5)
Expand All @@ -77,10 +79,10 @@ class NormalizerSuite extends FunSuite with LocalSparkContext {

assert((data2, data2RDD.collect()).zipped.forall((v1, v2) => v1 ~== v2 absTol 1E-5))

assert(data2(0).toBreeze.norm(2) ~== 1.0 absTol 1E-5)
assert(data2(2).toBreeze.norm(2) ~== 1.0 absTol 1E-5)
assert(data2(3).toBreeze.norm(2) ~== 1.0 absTol 1E-5)
assert(data2(4).toBreeze.norm(2) ~== 1.0 absTol 1E-5)
assert(brzNorm(data2(0).toBreeze, 2) ~== 1.0 absTol 1E-5)
assert(brzNorm(data2(2).toBreeze, 2) ~== 1.0 absTol 1E-5)
assert(brzNorm(data2(3).toBreeze, 2) ~== 1.0 absTol 1E-5)
assert(brzNorm(data2(4).toBreeze, 2) ~== 1.0 absTol 1E-5)

assert(data2(0) ~== Vectors.sparse(3, Seq((0, -0.65617871), (1, 0.75460552))) absTol 1E-5)
assert(data2(1) ~== Vectors.dense(0.0, 0.0, 0.0) absTol 1E-5)
Expand Down