[SPARK-30566][BUILD] Iterator doesn't refer outer identifier named "iterator" properly in Scala 2.13#27275
Closed
sarutak wants to merge 1 commit intoapache:masterfrom
Closed
[SPARK-30566][BUILD] Iterator doesn't refer outer identifier named "iterator" properly in Scala 2.13#27275sarutak wants to merge 1 commit intoapache:masterfrom
sarutak wants to merge 1 commit intoapache:masterfrom
Conversation
|
Test build #116981 has finished for PR 27275 at commit
|
Member
|
Looks fine. I don't remember that one in my local build for 2.13 but who knows :) |
HyukjinKwon
approved these changes
Jan 20, 2020
Member
|
Merged to master. |
Member
Author
|
@srowen Yeah, I'll tackle those issues for Scala 2.13. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Renamed an identifier
iteratortoiterto avoid compile error with Scala 2.13.Why are the changes needed?
As of Scala 2.13, scala.collection.Iterator has "iterator" method so if an inner class of Iterator means to refer an outer identifier named "iterator", it does not work as we think.
I listed source files that can be affected by that change by
find . -name "*.scala" -exec grep -El "new .*Iterator\[.* +{" {} \;As far as I confirmed util.Utils` is affected.
Does this PR introduce any user-facing change?
No.
How was this patch tested?
Existing tests.