Skip to content

[SPARK-30556][SQL] Copy sparkContext.localproperties to child thread inSubqueryExec.executionContext #27267

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
ajithme wants to merge 11 commits into from
Closed

[SPARK-30556][SQL] Copy sparkContext.localproperties to child thread inSubqueryExec.executionContext #27267

Changes from 1 commit
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
5042156
Copy localproperties to child thread of subquery execution
ajithme Jan 17, 2020
577904f
Update with UT
ajithme Jan 21, 2020
b6b5bae
Updated as per review comments
ajithme Jan 21, 2020
c2b157a
Update format
ajithme Jan 21, 2020
1ca7981
Update to accept active session also
ajithme Jan 21, 2020
fdc71e3
Update comment
ajithme Jan 21, 2020
aeea500
Review Comment
ajithme Jan 21, 2020
ade75c6
Make df creation method local
ajithme Jan 21, 2020
3f44356
Review Comments
ajithme Jan 22, 2020
89b95a3
Update style
ajithme Jan 22, 2020
f1cac4d
Review
ajithme Jan 22, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion sql/core/src/main/scala/org/apache/spark/sql/execution/basicPhysicalOperators.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,7 @@ import org.apache.spark.sql.catalyst.expressions.codegen._
import org.apache.spark.sql.catalyst.plans.physical._
import org.apache.spark.sql.execution.metric.SQLMetrics
import org.apache.spark.sql.types.{LongType, StructType}
import org.apache.spark.util.ThreadUtils
import org.apache.spark.util.{ThreadUtils, Utils}
import org.apache.spark.util.random.{BernoulliCellSampler, PoissonSampler}

/** Physical plan for Project. */
Expand Down Expand Up @@ -749,9 +749,11 @@ case class SubqueryExec(name: String, child: SparkPlan)
private lazy val relationFuture: Future[Array[InternalRow]] = {
// relationFuture is used in "doExecute". Therefore we can get the execution id correctly here.
val executionId = sparkContext.getLocalProperty(SQLExecution.EXECUTION_ID_KEY)
val localProps = Utils.cloneProperties(sparkContext.getLocalProperties)
Future {
// This will run in another thread. Set the execution id so that we can connect these jobs
// with the correct execution.
sparkContext.setLocalProperties(localProps)
SQLExecution.withExecutionId(sqlContext.sparkSession, executionId) {
val beforeCollect = System.nanoTime()
// Note that we use .executeCollect() because we don't want to convert data to Scala types
Expand Down