-
Notifications
You must be signed in to change notification settings - Fork 29k
[WIP][SPARK-30538][SQL] Control spark sql output small file by merge small partition #27248
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
Closed
Changes from all commits
Commits
Show all changes
6 commits
Select commit
Hold shift + click to select a range
06dc33c
update dev/lint-java
AngersZhuuuu 097bba9
Merge remote-tracking branch 'upstream/master'
AngersZhuuuu 7b44277
Merge branch 'master' of https://github.com/AngersZhuuuu/spark
AngersZhuuuu 2dabd51
control file output
AngersZhuuuu 230904a
sync
AngersZhuuuu 14cd426
fix
AngersZhuuuu File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
77 changes: 77 additions & 0 deletions
77
sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/SizeBasedCoalescer.scala
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,77 @@ | ||
| /* | ||
| * Licensed to the Apache Software Foundation (ASF) under one or more | ||
| * contributor license agreements. See the NOTICE file distributed with | ||
| * this work for additional information regarding copyright ownership. | ||
| * The ASF licenses this file to You under the Apache License, Version 2.0 | ||
| * (the "License"); you may not use this file except in compliance with | ||
| * the License. You may obtain a copy of the License at | ||
| * | ||
| * http://www.apache.org/licenses/LICENSE-2.0 | ||
| * | ||
| * Unless required by applicable law or agreed to in writing, software | ||
| * distributed under the License is distributed on an "AS IS" BASIS, | ||
| * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
| * See the License for the specific language governing permissions and | ||
| * limitations under the License. | ||
| */ | ||
|
|
||
| package org.apache.spark.sql.execution.datasources | ||
|
|
||
| import scala.collection.mutable.ArrayBuffer | ||
|
|
||
| import org.apache.spark.Partition | ||
| import org.apache.spark.rdd._ | ||
| import org.apache.spark.sql.catalyst.expressions.Attribute | ||
| import org.apache.spark.sql.catalyst.plans.logical.statsEstimation.EstimationUtils | ||
|
|
||
| class SizeBasedCoalescer(val maxSize: Long, val schema: Seq[Attribute]) | ||
| extends PartitionCoalescer with Serializable { | ||
| override def coalesce(maxPartitions: Int, parent: RDD[_]): Array[PartitionGroup] = { | ||
| val rowSize = EstimationUtils.getSizePerRow(schema).toLong | ||
| val partitionIndexToSize = parent.mapPartitionsWithIndexInternal((index, part) => { | ||
| // TODO make it more accurate | ||
| Map(index -> rowSize * part.size).iterator | ||
| }).collectAsMap() | ||
|
|
||
| val partitions = parent.partitions | ||
|
|
||
| val groups = ArrayBuffer[PartitionGroup]() | ||
| var currentGroup = new PartitionGroup() | ||
| var currentSum = 0L | ||
| var totalSum = 0L | ||
| var index = 0 | ||
|
|
||
| def updateGroups(): Unit = { | ||
| groups += currentGroup | ||
| currentGroup = new PartitionGroup() | ||
| currentSum = 0 | ||
| } | ||
|
|
||
| def addPartition(partition: Partition, splitSize: Long): Unit = { | ||
| currentGroup.partitions += partition | ||
| currentSum += splitSize | ||
| totalSum += splitSize | ||
| } | ||
|
|
||
| while (index < partitions.length) { | ||
| val partition = partitions(index) | ||
| val partitionSize = partitionIndexToSize(index) | ||
| if (currentSum + partitionSize < maxSize) { | ||
| addPartition(partition, partitionSize) | ||
| } else { | ||
| if (currentGroup.partitions.isEmpty) { | ||
| addPartition(partition, partitionSize) | ||
| } else { | ||
| updateGroups() | ||
| addPartition(partition, partitionSize) | ||
| } | ||
| } | ||
| index += 1 | ||
| if (index == partitions.length) { | ||
| updateGroups() | ||
| } | ||
| } | ||
| groups.toArray | ||
| } | ||
| } | ||
|
|
||
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is it too costly to trigger an action to compute all the RDDs?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this is after compute rdds and coalese computed rdd.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry for I have make some mistake, it will re-compute last stage. but won't recompute all stage