Skip to content

[SPARK-27868][CORE][FOLLOWUP] Recover the default value to -1 again #27230

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
xCASx wants to merge 1 commit into from
+9 −4
Closed

[SPARK-27868][CORE][FOLLOWUP] Recover the default value to -1 again #27230

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 6 additions & 2 deletions common/network-common/src/main/java/org/apache/spark/network/util/TransportConf.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -108,8 +108,12 @@ public int numConnectionsPerPeer() {
return conf.getInt(SPARK_NETWORK_IO_NUMCONNECTIONSPERPEER_KEY, 1);
}

/** Requested maximum length of the queue of incoming connections. Default is 64. */
public int backLog() { return conf.getInt(SPARK_NETWORK_IO_BACKLOG_KEY, 64); }
/**
* Requested maximum length of the queue of incoming connections. If < 1,
Copy link
Member

@dongjoon-hyun dongjoon-hyun Jan 17, 2020 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@xCASx . < 1 looks a little strange. Can we revise?

Copy link
Contributor Author

@xCASx xCASx Jan 17, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Here is how it implemented:

if (conf.backLog() > 0) {
  bootstrap.option(ChannelOption.SO_BACKLOG, conf.backLog());
}

I've been thinking about wording. If use 0 or negative instead of < 1 it may seem that separately mentioned 0 is some special case different to negative values.

For me it's not a big deal, if you'd like, I can change it to 0 or negative.

Copy link
Member

@dongjoon-hyun dongjoon-hyun Jan 17, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What I meant was If < 1 looks strange grammatically to me.

* the default Netty value of {@link io.netty.util.NetUtil#SOMAXCONN} will be used.
* Default to -1.
*/
public int backLog() { return conf.getInt(SPARK_NETWORK_IO_BACKLOG_KEY, -1); }

/** Number of threads used in the server thread pool. Default to 0, which is 2x#cores. */
public int serverThreads() { return conf.getInt(SPARK_NETWORK_IO_SERVERTHREADS_KEY, 0); }
Expand Down
5 changes: 3 additions & 2 deletions docs/configuration.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -844,13 +844,14 @@ Apart from these, the following properties are also available, and may be useful
</tr>
<tr>
<td><code>spark.shuffle.io.backLog</code></td>
<td>64</td>
<td>-1</td>
<td>
Length of the accept queue for the shuffle service. For large applications, this value may
need to be increased, so that incoming connections are not dropped if the service cannot keep
up with a large number of connections arriving in a short period of time. This needs to
be configured wherever the shuffle service itself is running, which may be outside of the
application (see <code>spark.shuffle.service.enabled</code> option below).
application (see <code>spark.shuffle.service.enabled</code> option below). If set below 1,
Copy link
Member

@dongjoon-hyun dongjoon-hyun Jan 17, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just to be clear, do you mean 0 and negative values by If set below 1?

Copy link
Contributor Author

@xCASx xCASx Jan 17, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes

will fallback to OS default defined by Netty's <code>io.netty.util.NetUtil#SOMAXCONN</code>.
</td>
</tr>
<tr>
Expand Down