Skip to content

Conversation

@Ishiihara
Copy link
Contributor

This is a working in progress PR. This PR reimplement Left/Right outer join using only one hash table.

@Ishiihara
Copy link
Contributor Author

This depends on #2719

@AmplabJenkins
Copy link

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/21499/Test FAILed.

@AmplabJenkins
Copy link

Can one of the admins verify this patch?

Conflicts:
	sql/core/src/main/scala/org/apache/spark/sql/execution/joins.scala
@Ishiihara
Copy link
Contributor Author

test this please

@marmbrus
Copy link
Contributor

ok to test

@SparkQA
Copy link

SparkQA commented Oct 28, 2014

QA tests have started for PR 2723 at commit 6aea59c.

  • This patch does not merge cleanly.

@SparkQA
Copy link

SparkQA commented Oct 28, 2014

QA tests have finished for PR 2723 at commit 6aea59c.

  • This patch fails Spark unit tests.
  • This patch does not merge cleanly.
  • This patch adds no public classes.

@AmplabJenkins
Copy link

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/22381/
Test FAILed.

Conflicts:
	sql/core/src/test/scala/org/apache/spark/sql/JoinSuite.scala
@SparkQA
Copy link

SparkQA commented Oct 29, 2014

Test build #22408 has started for PR 2723 at commit 91b182f.

  • This patch merges cleanly.

@AmplabJenkins
Copy link

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/22407/
Test FAILed.

@Ishiihara
Copy link
Contributor Author

test this please

@SparkQA
Copy link

SparkQA commented Oct 29, 2014

Test build #22408 has finished for PR 2723 at commit 91b182f.

  • This patch fails Spark unit tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@AmplabJenkins
Copy link

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/22408/
Test FAILed.

@SparkQA
Copy link

SparkQA commented Oct 29, 2014

Test build #22411 has started for PR 2723 at commit 91b182f.

  • This patch merges cleanly.

@SparkQA
Copy link

SparkQA commented Oct 29, 2014

Test build #22411 has finished for PR 2723 at commit 91b182f.

  • This patch fails Spark unit tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@AmplabJenkins
Copy link

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/22411/
Test FAILed.

@Ishiihara
Copy link
Contributor Author

@marmbrus All test failures have the same pattern

select * from a right outer join b on condition1 join c on condition2

With the extra join operation, somehow the iterator of a join b does not output all the values of the join result. However,

select * from a right outer join b on a.key = b.key

returns the correct result. I am currently investigating the cause of the failures, please let me know if you have any ideas. Thanks!

@marmbrus
Copy link
Contributor

marmbrus commented Dec 2, 2014

Thanks for working on this, but we are trying to clean up the PR queue (in order to make it easier for us to review). Thus, I think we should close this issue for now and reopen when its ready for review.

@asfgit asfgit closed this in b0a46d8 Dec 2, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants