-
Notifications
You must be signed in to change notification settings - Fork 29k
[WIP][SQL][SPARK-3839] Reimplement Left/Right outer join #2723
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
This depends on #2719 |
|
Test FAILed. |
|
Can one of the admins verify this patch? |
Conflicts: sql/core/src/main/scala/org/apache/spark/sql/execution/joins.scala
|
test this please |
|
ok to test |
|
QA tests have started for PR 2723 at commit
|
|
QA tests have finished for PR 2723 at commit
|
|
Test FAILed. |
Conflicts: sql/core/src/test/scala/org/apache/spark/sql/JoinSuite.scala
|
Test build #22408 has started for PR 2723 at commit
|
|
Test FAILed. |
|
test this please |
|
Test build #22408 has finished for PR 2723 at commit
|
|
Test FAILed. |
|
Test build #22411 has started for PR 2723 at commit
|
|
Test build #22411 has finished for PR 2723 at commit
|
|
Test FAILed. |
|
@marmbrus All test failures have the same pattern With the extra join operation, somehow the iterator of a join b does not output all the values of the join result. However, returns the correct result. I am currently investigating the cause of the failures, please let me know if you have any ideas. Thanks! |
|
Thanks for working on this, but we are trying to clean up the PR queue (in order to make it easier for us to review). Thus, I think we should close this issue for now and reopen when its ready for review. |
This is a working in progress PR. This PR reimplement Left/Right outer join using only one hash table.