Skip to content

Conversation

@mtimper
Copy link

@mtimper mtimper commented Oct 8, 2014

In JSONRDD.scala, add 'case TimestampType' in the enforceCorrectType function and a toTimestamp function.

@AmplabJenkins
Copy link

Can one of the admins verify this patch?

@marmbrus
Copy link
Contributor

marmbrus commented Oct 9, 2014

ok to test

@marmbrus
Copy link
Contributor

marmbrus commented Oct 9, 2014

Can you rename this [SPARK-3853][SQL] JSON Schema support for Timestamp fields or something similarly descriptive?

@AmplabJenkins
Copy link

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/21498/Test FAILed.

@SparkQA
Copy link

SparkQA commented Oct 9, 2014

QA tests have started for PR 2720 at commit 9386ab8.

  • This patch merges cleanly.

@SparkQA
Copy link

SparkQA commented Oct 9, 2014

QA tests have finished for PR 2720 at commit 9386ab8.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@mtimper mtimper changed the title Fix and tests for SPARK-3853 [SPARK-3853][SQL] JSON Schema support for Timestamp fields Oct 9, 2014
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actually one more thing. Will this handle null values? I think you'll get a match error.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Isn't null being checked for at the beginning enforceCorrectType? Though, I can add it here if you think it is needed.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh, right. Cool.

@AmplabJenkins
Copy link

Can one of the admins verify this patch?

@marmbrus
Copy link
Contributor

marmbrus commented Oct 9, 2014

Thanks! I've merged this to master.

@asfgit asfgit closed this in ec4d40e Oct 9, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants