-
Notifications
You must be signed in to change notification settings - Fork 29k
[SPARK-3853][SQL] JSON Schema support for Timestamp fields #2720
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Can one of the admins verify this patch? |
|
ok to test |
|
Can you rename this |
|
Test FAILed. |
|
QA tests have started for PR 2720 at commit
|
|
QA tests have finished for PR 2720 at commit
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actually one more thing. Will this handle null values? I think you'll get a match error.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Isn't null being checked for at the beginning enforceCorrectType? Though, I can add it here if you think it is needed.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh, right. Cool.
|
Can one of the admins verify this patch? |
|
Thanks! I've merged this to master. |
In JSONRDD.scala, add 'case TimestampType' in the enforceCorrectType function and a toTimestamp function.