Skip to content

Conversation

@zero323
Copy link
Member

@zero323 zero323 commented Jan 13, 2020

What changes were proposed in this pull request?

This PR adds setInputCol and setOutputCol methods to ImputerModel

Why are the changes needed?

Feature parity. These methods are already present in Scala:

/** @group setParam */
@Since("3.0.0")
def setInputCol(value: String): this.type = set(inputCol, value)
/** @group setParam */
@Since("3.0.0")
def setOutputCol(value: String): this.type = set(outputCol, value)

Does this PR introduce any user-facing change?

PySpark ImputerModel now supports setters for single column workflow.

How was this patch tested?

Manual tests (should we add Python unit tests, as Imputer is not covered at all?).

@SparkQA
Copy link

SparkQA commented Jan 13, 2020

Test build #116666 has finished for PR 27195 at commit 1adc184.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@zero323
Copy link
Member Author

zero323 commented Jan 14, 2020

Closing as #26247 (comment)

@zero323 zero323 closed this Jan 14, 2020
@zero323 zero323 deleted the SPARK-29566-follow-up branch January 14, 2020 00:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants