[SPARK-30267][SQL][FollowUp] Use while loop in Avro Array Deserializer #27127
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
|
Test build #116281 has finished for PR 27127 at commit
|
steven-aerts
approved these changes
Jan 8, 2020
Contributor
steven-aerts
left a comment
steven-aerts
left a comment
There was a problem hiding this comment.
I wrote a small benchmark for this.
The zipWithIndex is of course very slow.
This change gains a little bit, but not significantly.
Another nice idiom i think is:
for(element:collection.iterator().asScala)
Which is also very fast.
Member
Author
|
@steven-aerts Thanks for the benchmark! |
Member
Author
|
Merging to master. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
This is a follow-up of #26907
It changes the for loop
for (element <- array.asScala)to while loopWhy are the changes needed?
As per https://github.com/databricks/scala-style-guide#traversal-and-zipwithindex, we should use while loop for the performance-sensitive code.
Does this PR introduce any user-facing change?
No
How was this patch tested?
Existing tests.