Skip to content

[SPARK-3844][UI] Truncate appName in WebUI if it is too long #2707

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
mengxr wants to merge 2 commits into from
Closed

[SPARK-3844][UI] Truncate appName in WebUI if it is too long #2707

mengxr wants to merge 2 commits into from

Conversation

@mengxr
Copy link
Contributor

@mengxr mengxr commented Oct 8, 2014

Truncate appName in WebUI if it is too long.

@mengxr mengxr mentioned this pull request Oct 8, 2014
Closed
@SparkQA
Copy link

SparkQA commented Oct 8, 2014

QA tests have started for PR 2707 at commit c7111dc.

  • This patch merges cleanly.

@SparkQA
Copy link

SparkQA commented Oct 8, 2014

QA tests have finished for PR 2707 at commit c7111dc.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@AmplabJenkins
Copy link

AmplabJenkins commented Oct 8, 2014

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/21454/Test PASSed.

@mengxr
Copy link
Contributor Author

mengxr commented Oct 8, 2014

example:

title

@andrewor14
Copy link
Contributor

andrewor14 commented Oct 8, 2014

Great, LGTM.

@SparkQA
Copy link

SparkQA commented Oct 8, 2014

QA tests have started for PR 2707 at commit 87834ce.

  • This patch merges cleanly.

@SparkQA
Copy link

SparkQA commented Oct 8, 2014

QA tests have finished for PR 2707 at commit 87834ce.

  • This patch fails Spark unit tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@AmplabJenkins
Copy link

AmplabJenkins commented Oct 8, 2014

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/21471/Test FAILed.

@mengxr
Copy link
Contributor Author

mengxr commented Oct 8, 2014

test this please

@SparkQA
Copy link

SparkQA commented Oct 8, 2014

QA tests have started for PR 2707 at commit 87834ce.

  • This patch merges cleanly.

@SparkQA
Copy link

SparkQA commented Oct 8, 2014

Tests timed out for PR 2707 at commit 87834ce after a configured wait of 120m.

@AmplabJenkins
Copy link

AmplabJenkins commented Oct 8, 2014

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/21477/Test FAILed.

@andrewor14
Copy link
Contributor

andrewor14 commented Oct 8, 2014

retest this please

@AmplabJenkins
Copy link

AmplabJenkins commented Oct 8, 2014

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/21483/Test FAILed.

@mengxr
Copy link
Contributor Author

mengxr commented Oct 8, 2014

test this please

@AmplabJenkins
Copy link

AmplabJenkins commented Oct 8, 2014

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/21484/Test FAILed.

@pwendell
Copy link
Contributor

pwendell commented Oct 8, 2014

What about instead wrapping this in the UI - as it stands now this could be lossy if people have unique identifiers at the end of the app name.

@mengxr
Copy link
Contributor Author

mengxr commented Oct 8, 2014

User can mouse over the truncated app name to see the full name in the tooltip. If the app name is really long, wrapping it doesn't help:

screen shot 2014-10-08 at 3 54 51 pm

@andrewor14
Copy link
Contributor

andrewor14 commented Oct 9, 2014

retest this please?

@AmplabJenkins
Copy link

AmplabJenkins commented Oct 9, 2014

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/21503/Test FAILed.

@SparkQA
Copy link

SparkQA commented Oct 9, 2014

QA tests have started for PR 2707 at commit 87834ce.

  • This patch merges cleanly.

@pwendell
Copy link
Contributor

pwendell commented Oct 9, 2014

Ah I see- okay makes sense.

@SparkQA
Copy link

SparkQA commented Oct 9, 2014

QA tests have finished for PR 2707 at commit 87834ce.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@andrewor14
Copy link
Contributor

andrewor14 commented Oct 9, 2014

Ok, I'm merging this into master and 1.1

guavuslabs-builder pushed a commit to ThalesGroup/spark that referenced this pull request Oct 9, 2014
@mengxr @andrewor14
[SPARK-3844][UI] Truncate appName in WebUI if it is too long
09d6a81 
Truncate appName in WebUI if it is too long.

Author: Xiangrui Meng <[email protected]>

Closes apache#2707 from mengxr/truncate-app-name and squashes the following commits:

87834ce [Xiangrui Meng] move scala import below java
c7111dc [Xiangrui Meng] truncate appName in WebUI if it is too long

(cherry picked from commit 86b3929)
Signed-off-by: Andrew Or <[email protected]>
@asfgit asfgit closed this in 86b3929 Oct 9, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@mengxr @SparkQA @AmplabJenkins @andrewor14 @pwendell