Skip to content

[SPARK-3824][SQL] Sets in-memory table default storage level to MEMORY_AND_DISK #2686

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
liancheng wants to merge 4 commits into from
Closed

[SPARK-3824][SQL] Sets in-memory table default storage level to MEMORY_AND_DISK #2686

liancheng wants to merge 4 commits into from

Conversation

@liancheng
Copy link
Contributor

@liancheng liancheng commented Oct 7, 2014

Using MEMORY_AND_DISK as default storage level for in-memory table caching. Due to the in-memory columnar representation, recomputing an in-memory cached table partitions can be very expensive.

@SparkQA
Copy link

SparkQA commented Oct 7, 2014

QA tests have started for PR 2686 at commit 07f0204.

  • This patch merges cleanly.

@SparkQA
Copy link

SparkQA commented Oct 7, 2014

QA tests have finished for PR 2686 at commit 07f0204.

  • This patch fails Spark unit tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@AmplabJenkins
Copy link

AmplabJenkins commented Oct 7, 2014

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/21359/Test FAILed.

liancheng
liancheng reviewed Oct 7, 2014
View reviewed changes
sql/core/src/test/scala/org/apache/spark/sql/CachedTableSuite.scala
Copy link
Contributor Author

@liancheng liancheng Oct 7, 2014

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

10GB exceeds Int.MaxValue, too big for FileChannel.map().

@SparkQA
Copy link

SparkQA commented Oct 7, 2014

QA tests have started for PR 2686 at commit 07f0204.

  • This patch merges cleanly.

@SparkQA
Copy link

SparkQA commented Oct 7, 2014

QA tests have started for PR 2686 at commit 1ab7967.

  • This patch merges cleanly.

@SparkQA
Copy link

SparkQA commented Oct 7, 2014

QA tests have finished for PR 2686 at commit 1ab7967.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@AmplabJenkins
Copy link

AmplabJenkins commented Oct 7, 2014

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/21362/Test PASSed.

@SparkQA
Copy link

SparkQA commented Oct 7, 2014

QA tests have finished for PR 2686 at commit 07f0204.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

aarondav
aarondav reviewed Oct 7, 2014
View reviewed changes
sql/core/src/main/scala/org/apache/spark/sql/columnar/InMemoryColumnarTableScan.scala Outdated
Copy link
Contributor

@aarondav aarondav Oct 7, 2014

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: remove space before .

Copy link
Contributor Author

@liancheng liancheng Oct 8, 2014

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, done.

@AmplabJenkins
Copy link

AmplabJenkins commented Oct 8, 2014

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/21434/Test FAILed.

@SparkQA
Copy link

SparkQA commented Oct 9, 2014

QA tests have started for PR 2686 at commit 35d2ed0.

  • This patch merges cleanly.

@SparkQA
Copy link

SparkQA commented Oct 9, 2014

QA tests have finished for PR 2686 at commit 35d2ed0.

  • This patch fails Spark unit tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@AmplabJenkins
Copy link

AmplabJenkins commented Oct 9, 2014

Can one of the admins verify this patch?

@liancheng
Copy link
Contributor Author

liancheng commented Oct 10, 2014

ok to test

@SparkQA
Copy link

SparkQA commented Oct 10, 2014

QA tests have started for PR 2686 at commit 35d2ed0.

  • This patch merges cleanly.

@SparkQA
Copy link

SparkQA commented Oct 10, 2014

QA tests have finished for PR 2686 at commit 35d2ed0.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@SparkQA
Copy link

SparkQA commented Oct 10, 2014

QA tests have started for PR 2686 at commit 35d2ed0.

  • This patch merges cleanly.

@marmbrus
Copy link
Contributor

marmbrus commented Oct 10, 2014

Thanks! Merged to master.

@asfgit asfgit closed this in 421382d Oct 10, 2014
@SparkQA
Copy link

SparkQA commented Oct 10, 2014

QA tests have finished for PR 2686 at commit 35d2ed0.

  • This patch fails Spark unit tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@wjur wjur mentioned this pull request Feb 12, 2016
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@liancheng @SparkQA @AmplabJenkins @marmbrus @aarondav