[SPARK-30196][BUILD] Bump lz4-java version to 1.7.0#26823
Closed
maropu wants to merge 2 commits intoapache:masterfrom
Closed
[SPARK-30196][BUILD] Bump lz4-java version to 1.7.0#26823maropu wants to merge 2 commits intoapache:masterfrom
maropu wants to merge 2 commits intoapache:masterfrom
Conversation
Member
Author
|
Test build #115056 has finished for PR 26823 at commit
|
Contributor
|
@maropu, it looks like you need to run: to update the dependency manifests. Thanks for submitting this PR! |
| <groupId>org.lz4</groupId> | ||
| <artifactId>lz4-java</artifactId> | ||
| <version>1.6.0</version> | ||
| <version>1.7.0</version> |
Member
There was a problem hiding this comment.
Could you update the dependency files with I missed @JoshRosen 's comment.dev/test-dependencies.sh --replace-manifest?
Member
Author
|
oh, I forgot to do so, thanks! I'll update soon. |
Member
|
LGTM, pending Jenkins |
|
Test build #115057 has finished for PR 26823 at commit
|
srowen
approved these changes
Dec 10, 2019
Member
|
Merged to master. |
Member
Author
|
Thanks, all. |
Member
|
Thank you all! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
This pr intends to upgrade lz4-java from 1.6.0 to 1.7.0.
Why are the changes needed?
This release includes a performance bug (lz4/lz4-java#143) fixed by @JoshRosen and some improvements (e.g., LZ4 binary update). You can see the link below for the changes;
https://github.com/lz4/lz4-java/blob/master/CHANGES.md#170
Does this PR introduce any user-facing change?
No
How was this patch tested?
Existing tests.