-
Notifications
You must be signed in to change notification settings - Fork 29k
[SPARK-30170][SQL][MLLIB][TESTS] Eliminate compilation warnings: part 1 #26799
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
Closed
Changes from all commits
Commits
Show all changes
7 commits
Select commit
Hold shift + click to select a range
604267b
import scala.language.implicitConversions
MaxGekk 1368ca3
Explicitly convert the Float with .toDouble in FloatType
MaxGekk 9711174
Fix the warning: "Octal escape literals are deprecated, use \u0000 in…
MaxGekk 6f47358
verifyZeroInteractions -> verifyNoInteractions
MaxGekk c46a4ce
Fix the warning: "Seq[String] is unchecked since it is eliminated by …
MaxGekk ce83a11
Handle the default case in MLTest
MaxGekk 9a954fd
Change the order of imports in CollectionExpressionsSuite
MaxGekk File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -88,6 +88,8 @@ trait MLTest extends StreamTest with TempDirectory { self: Suite => | |
| val n = Attribute.fromStructField(dataframe.schema(colName)) match { | ||
| case binAttr: BinaryAttribute => Some(2) | ||
| case nomAttr: NominalAttribute => nomAttr.getNumValues | ||
| case unknown => | ||
| throw new IllegalArgumentException(s"Attribute type: ${unknown.getClass.getName}") | ||
|
Member
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. |
||
| } | ||
| assert(n.isDefined && n.get === numValues, | ||
| s"the number of values obtained from schema should be $numValues, but got $n") | ||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -59,7 +59,7 @@ class AnalysisExternalCatalogSuite extends AnalysisTest with Matchers { | |
| Alias(UnresolvedFunction("sum", Seq(UnresolvedAttribute("a")), isDistinct = false), "s")() | ||
| val plan = Project(Seq(func), testRelation) | ||
| analyzer.execute(plan) | ||
| verifyZeroInteractions(catalog) | ||
| verifyNoInteractions(catalog) | ||
|
Member
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. |
||
| } | ||
| } | ||
|
|
||
|
|
@@ -73,7 +73,7 @@ class AnalysisExternalCatalogSuite extends AnalysisTest with Matchers { | |
| ignoreIfExists = false) | ||
| reset(externCatalog) | ||
| catalog.functionExists(FunctionIdentifier("sum")) | ||
| verifyZeroInteractions(externCatalog) | ||
| verifyNoInteractions(externCatalog) | ||
| } | ||
| } | ||
|
|
||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -20,6 +20,7 @@ package org.apache.spark.sql.catalyst.expressions | |
| import java.sql.{Date, Timestamp} | ||
| import java.util.TimeZone | ||
|
|
||
| import scala.language.implicitConversions | ||
|
Member
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. |
||
| import scala.util.Random | ||
|
|
||
| import org.apache.spark.SparkFunSuite | ||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.