Skip to content

[SPARK-30093][SQL] Improve error message for creating view #26731

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
amanomer wants to merge 4 commits into from
Closed

[SPARK-30093][SQL] Improve error message for creating view #26731

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
bd45562
Initial commit
amanomer Dec 2, 2019
6e9f061
nit
amanomer Dec 3, 2019
8456ecd
updated TC
amanomer Dec 3, 2019
7815d6e
Fixed TC
amanomer Dec 4, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion sql/core/src/main/scala/org/apache/spark/sql/execution/command/views.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -162,7 +162,7 @@ case class CreateViewCommand(
if sparkSession.sessionState.catalog.isTemporaryTable(ident) =>
// temporary views are only stored in the session catalog
throw new AnalysisException(s"Not allowed to create a permanent view $name by " +
s"referencing a temporary view $ident")
s"referencing a temporary view $ident (use TEMPORARY keyword)")
Copy link
Contributor

@cloud-fan cloud-fan Dec 3, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: ... referencing a temporary view $ident. Please create a temp view instead by CREATE TEMP VIEW

Copy link
Contributor Author

@amanomer amanomer Dec 3, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done.

case other if !other.resolved => other.expressions.flatMap(_.collect {
// Traverse subquery plan for any unresolved relations.
case e: SubqueryExpression => verify(e.plan)
Expand Down