Skip to content

[SPARK-30060][CORE] Rename metrics enable/disable configs #26692

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
LucaCanali wants to merge 2 commits into from
Closed

[SPARK-30060][CORE] Rename metrics enable/disable configs #26692

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
852e865
Rename metrics enable/disable configs
LucaCanali Nov 29, 2019
49052de
Renamed APP_STATUS_METRICS_ENABLED to METRICS_APP_STATUS_SOURCE_ENABLED
LucaCanali Dec 3, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions core/src/main/scala/org/apache/spark/internal/config/Status.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -55,8 +55,8 @@ private[spark] object Status {
.intConf
.createWithDefault(Int.MaxValue)

val APP_STATUS_METRICS_ENABLED =
ConfigBuilder("spark.app.status.metrics.enabled")
val METRICS_APP_STATUS_SOURCE_ENABLED =
ConfigBuilder("spark.metrics.appStatusSource.enabled")
.doc("Whether Dropwizard/Codahale metrics " +
"will be reported for the status of the running spark app.")
.booleanConf
Expand Down
2 changes: 1 addition & 1 deletion core/src/main/scala/org/apache/spark/internal/config/package.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -638,7 +638,7 @@ package object config {
.createOptional

private[spark] val METRICS_STATIC_SOURCES_ENABLED =
ConfigBuilder("spark.metrics.static.sources.enabled")
ConfigBuilder("spark.metrics.staticSources.enabled")
.doc("Whether to register static sources with the metrics system.")
.booleanConf
.createWithDefault(true)
Expand Down
4 changes: 2 additions & 2 deletions core/src/main/scala/org/apache/spark/status/AppStatusSource.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@ import AppStatusSource.getCounter
import com.codahale.metrics.{Counter, Gauge, MetricRegistry}

import org.apache.spark.SparkConf
import org.apache.spark.internal.config.Status.APP_STATUS_METRICS_ENABLED
import org.apache.spark.internal.config.Status.METRICS_APP_STATUS_SOURCE_ENABLED
import org.apache.spark.metrics.source.Source

private [spark] class JobDuration(val value: AtomicLong) extends Gauge[Long] {
Expand Down Expand Up @@ -71,7 +71,7 @@ private[spark] object AppStatusSource {
}

def createSource(conf: SparkConf): Option[AppStatusSource] = {
Option(conf.get(APP_STATUS_METRICS_ENABLED))
Option(conf.get(METRICS_APP_STATUS_SOURCE_ENABLED))
.filter(identity)
.map { _ => new AppStatusSource() }
}
Expand Down
12 changes: 6 additions & 6 deletions docs/monitoring.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -924,7 +924,7 @@ This is the component with the largest amount of instrumented metrics

- namespace=HiveExternalCatalog
- **note:**: these metrics are conditional to a configuration parameter:
`spark.metrics.static.sources.enabled` (default is true)
`spark.metrics.staticSources.enabled` (default is true)
- fileCacheHits.count
- filesDiscovered.count
- hiveClientCalls.count
Expand All @@ -933,7 +933,7 @@ This is the component with the largest amount of instrumented metrics

- namespace=CodeGenerator
- **note:**: these metrics are conditional to a configuration parameter:
`spark.metrics.static.sources.enabled` (default is true)
`spark.metrics.staticSources.enabled` (default is true)
- compilationTime (histogram)
- generatedClassSize (histogram)
- generatedMethodSize (histogram)
Expand Down Expand Up @@ -962,8 +962,8 @@ This is the component with the largest amount of instrumented metrics
- queue.executorManagement.listenerProcessingTime (timer)

- namespace=appStatus (all metrics of type=counter)
- **note:** Introduced in Spark 3.0. Conditional to configuration parameter:
`spark.app.status.metrics.enabled=true` (default is false)
- **note:** Introduced in Spark 3.0. Conditional to a configuration parameter:
`spark.metrics.appStatusSource.enabled` (default is false)
- stages.failedStages.count
- stages.skippedStages.count
- stages.completedStages.count
Expand Down Expand Up @@ -1057,7 +1057,7 @@ when running in local mode.

- namespace=HiveExternalCatalog
- **note:**: these metrics are conditional to a configuration parameter:
`spark.metrics.static.sources.enabled` (default is true)
`spark.metrics.staticSources.enabled` (default is true)
- fileCacheHits.count
- filesDiscovered.count
- hiveClientCalls.count
Expand All @@ -1066,7 +1066,7 @@ when running in local mode.

- namespace=CodeGenerator
- **note:**: these metrics are conditional to a configuration parameter:
`spark.metrics.static.sources.enabled` (default is true)
`spark.metrics.staticSources.enabled` (default is true)
- compilationTime (histogram)
- generatedClassSize (histogram)
- generatedMethodSize (histogram)
Expand Down