Skip to content

[SPARK-30030][INFRA] Use RegexChecker instead of TokenChecker to check org.apache.commons.lang. #26666

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
dongjoon-hyun wants to merge 2 commits into from
Closed

[SPARK-30030][INFRA] Use RegexChecker instead of TokenChecker to check org.apache.commons.lang. #26666

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
3989356
[SPARK-29081][CORE][FOLLOWUP] Use commons-lang3 instead of commons-lang2
dongjoon-hyun Nov 25, 2019
f3b84d8
Update
dongjoon-hyun Nov 25, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion core/src/test/scala/org/apache/spark/util/PropertiesCloneBenchmark.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@ import java.util.Properties

import scala.util.Random

import org.apache.commons.lang.SerializationUtils
import org.apache.commons.lang3.SerializationUtils

import org.apache.spark.benchmark.{Benchmark, BenchmarkBase}

Expand Down
2 changes: 1 addition & 1 deletion scalastyle-config.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -258,7 +258,7 @@ This file is divided into 3 sections:
scala.collection.JavaConverters._ and use .asScala / .asJava methods</customMessage>
</check>

<check customId="commonslang2" level="error" class="org.scalastyle.scalariform.TokenChecker" enabled="true">
<check customId="commonslang2" level="error" class="org.scalastyle.file.RegexChecker" enabled="true">
Copy link
Member Author

@dongjoon-hyun dongjoon-hyun Nov 25, 2019 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@srowen and @databricks-david-lewis . This was the root cause.
I'm not sure if there is any change inside TokenChecker, but RegexChecker is better at detecting org.apache.commons.lang. since it's not a token.

<parameters><parameter name="regex">org\.apache\.commons\.lang\.</parameter></parameters>
<customMessage>Use Commons Lang 3 classes (package org.apache.commons.lang3.*) instead
of Commons Lang 2 (package org.apache.commons.lang.*)</customMessage>
Expand Down