-
Notifications
You must be signed in to change notification settings - Fork 29k
[SPARK-30025][Core] Continuous shuffle block fetching should be disabled by default when the old fetch protocol is used #26663
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
just for curiosity, how things can go wrong if we do batch fetch with old shuffle protocol? the shuffle server can't recognize the new request and fail? |
|
Test build #114403 has finished for PR 26663 at commit
|
That's the scenario Yuming met at https://github.com/apache/spark/pull/26147/files#r348943508. |
common/network-shuffle/src/main/java/org/apache/spark/network/shuffle/ExternalBlockHandler.java
Outdated
Show resolved
Hide resolved
core/src/main/scala/org/apache/spark/network/netty/NettyBlockRpcServer.scala
Outdated
Show resolved
Hide resolved
|
Test build #114450 has finished for PR 26663 at commit
|
ba84e6a to
892da74
Compare
|
Test build #114620 has finished for PR 26663 at commit
|
…the old fetch protocol is used
892da74 to
9c53b4a
Compare
|
Test build #114703 has finished for PR 26663 at commit
|
|
thanks, merging to master! |
|
Thanks! |
…led by default when the old fetch protocol is used ### What changes were proposed in this pull request? Disable continuous shuffle block fetching when the old fetch protocol in use. ### Why are the changes needed? The new feature of continuous shuffle block fetching depends on the latest version of the shuffle fetch protocol. We should keep this constraint in `BlockStoreShuffleReader.fetchContinuousBlocksInBatch`. ### Does this PR introduce any user-facing change? Users will not get the exception related to continuous shuffle block fetching when old version of the external shuffle service is used. ### How was this patch tested? Existing UT. Closes apache#26663 from xuanyuanking/SPARK-30025. Authored-by: Yuanjian Li <[email protected]> Signed-off-by: Wenchen Fan <[email protected]>
What changes were proposed in this pull request?
Disable continuous shuffle block fetching when the old fetch protocol in use.
Why are the changes needed?
The new feature of continuous shuffle block fetching depends on the latest version of the shuffle fetch protocol. We should keep this constraint in
BlockStoreShuffleReader.fetchContinuousBlocksInBatch.Does this PR introduce any user-facing change?
Users will not get the exception related to continuous shuffle block fetching when old version of the external shuffle service is used.
How was this patch tested?
Existing UT.