[SPARK-29554][SQL][FOLLOWUP] Rename Version to SparkVersion #26647
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maropu
approved these changes
Nov 24, 2019
Member
Author
|
Thank you for review and approval, @maropu . |
dongjoon-hyun
commented
Nov 24, 2019
Member
Author
dongjoon-hyun
left a comment
dongjoon-hyun
left a comment
There was a problem hiding this comment.
All compilation tests passed and MiscFunctionsSuite is tested locally.
Merged to master. Thank you, @maropu .
|
Test build #114330 has finished for PR 26647 at commit
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
This is a follow-up of #26209 .
This renames class
Versionto classSparkVersion.Why are the changes needed?
According to the review comment, this uses more specific class name.
Does this PR introduce any user-facing change?
No.
How was this patch tested?
Pass the Jenkins with the existing tests.