-
Notifications
You must be signed in to change notification settings - Fork 29k
[SPARK-25351][SQL][Python] Handle Pandas category type when converting from Python with Arrow #26585
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
jalpan-randeri
wants to merge
14
commits into
apache:master
from
jalpan-randeri:feature-pyarrow-dictionary-type
Closed
[SPARK-25351][SQL][Python] Handle Pandas category type when converting from Python with Arrow #26585
Changes from all commits
Commits
Show all changes
14 commits
Select commit
Hold shift + click to select a range
6b409e6
pyarrow dictionary type fix
5fb9de5
merged from master
9733be2
applied dictionary category patch in new oss commits
d74389c
category type conversion tests arrow
aa8c5f6
Merge branch 'temp-oss' into feature-pyarrow-dictionary-type
a8d3173
fixed merge conflicts in python for category type support
333f37c
resolve missing commit from master
1a2447b
use with in tests
24971d4
removed category import & assert_frame in test
bcb877a
scalar udf test
99d5026
fix me to remove category conversion for pyarrow > 16
e3246ad
lint fix too many lines in test_udf_scaler
9f04f1b
cr feedback, proper udf test instead of create dataframe
7aa9fcd
python checkstyle fixes
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
could you add an assert that the Spark DataFrame has column "B" as a string type?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done, move other test checks here too.