[SPARK-29902][Doc][Minor]Add listener event queue capacity configuration to documentation#26529
[SPARK-29902][Doc][Minor]Add listener event queue capacity configuration to documentation#26529shahidki31 wants to merge 3 commits intoapache:masterfrom
Conversation
|
cc @srowen Kindly review |
|
Test build #113804 has finished for PR 26529 at commit
|
docs/configuration.md
Outdated
| <td><code>spark.scheduler.listenerbus.eventqueue.appStatus.capacity</code></td> | ||
| <td><code>spark.scheduler.listenerbus.eventqueue.capacity</code></td> | ||
| <td> | ||
| Capacity for appStatus event queue in Spark listener bus, must be greater than 0. |
There was a problem hiding this comment.
"appStatus event queue hold events for internal application status listeners" is useful; "Capacity for appStatus event queue in Spark listener bus" seems sort of redundant. I'd maybe lead with "Capacity of the appStatus event queue, which holds events ..." just once. Here and elsewhere.
docs/configuration.md
Outdated
| <td><code>spark.scheduler.listenerbus.eventqueue.capacity</code></td> | ||
| <td> | ||
| Capacity for shared event queue in Spark listener bus, must be greater than 0. | ||
| Unless otherwise specified it uses <code>spark.scheduler.listenerbus.eventqueue.capacity</code>. |
There was a problem hiding this comment.
I think this is covered already by the fact that this is shown as the default here. You can remove it everywhere.
|
Test build #113812 has finished for PR 26529 at commit
|
|
Test build #113813 has finished for PR 26529 at commit
|
|
Retest this please |
|
Test build #113816 has finished for PR 26529 at commit
|
|
retest this please |
|
Test build #113853 has finished for PR 26529 at commit
|
|
I am not sure why the checks are failing. Seems unrelated error? |
|
You can ignore the checks below at the moment. It is unrelated. |
|
Merged to master |
|
Thanks @srowen |
|
#25307 (comment) |
|
Hm, good question. They're not explicitly marked internal, and I don't expect (?) they'll change. At the least maybe this could carry a comment that the names of the queues are subject to change. |
|
@jiangxb1987 I think from the console/logs , user can get to know exactly from which queue event drop has happened and how many events dropped from that particular queue. Also user can see which event has dropped, if enable the trace. |
What changes were proposed in this pull request?
Add listener event queue capacity configuration to documentation
Why are the changes needed?
We some time see many event drops happening in eventLog listener queue. So, instead of increasing all the queues size, using this config we just need to increase eventLog queue capacity.
Does this PR introduce any user-facing change?
No
How was this patch tested?
Existing tests