[SPARK-29816][MLLIB] Missing persist in mllib.evaluation.BinaryClassificationMetrics.recallByThreshold() #26447
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can one of the admins verify this patch? |
amanomer
changed the title
Contributor
Author
|
@MaxGekk Kindly review this PR. |
Member
|
There's no reason this has to be like 5 JIRAs and PRs. Just combine them into one, please. |
Contributor
Author
|
Okay. |
MaxGekk
reviewed
Nov 9, 2019
| mergeCombiners = (c1: BinaryLabelCounter, c2: BinaryLabelCounter) => c1 += c2 | ||
| ).sortByKey(ascending = false) | ||
| ) | ||
| binnedWeights.persist() |
Member
There was a problem hiding this comment.
Could you explain why do you persist binnedWeights but not counts? As I can see binnedWeights is used only once ... or I missed something?
Contributor
Author
There was a problem hiding this comment.
Rdd scoreAndLabels.combineByKey is found to be used more than one time, as mentioned in SPARK-29816.
I think, counts rdd is constructed over scoreAndLabels.combineByKey after action sortByKey. counts is indirectly dependent on scoreAndLabels.combineByKey i.e, binnedWeights?
Member
|
Let's please merge this to #26454 after discussing some initial principles there. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Use
persiston RDD which is used for more than one action.Why are the changes needed?
The rdd
scoreAndLabels.combineByKeyis used by two actions:sortByKeyandcount, so it needs to be persisted.Does this PR introduce any user-facing change?
No
How was this patch tested?
Tested manually.