[SPARK-29753][SQL] refine the default catalog config #26395
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
Test build #113250 has finished for PR 26395 at commit
|
|
Test build #113269 has finished for PR 26395 at commit
|
imback82
approved these changes
Nov 5, 2019
Contributor
imback82
left a comment
imback82
left a comment
There was a problem hiding this comment.
LGTM (one minor comment)
| val DEFAULT_V2_CATALOG = buildConf("spark.sql.default.catalog") | ||
| .doc("Name of the default v2 catalog, used when a catalog is not identified in queries") | ||
| val DEFAULT_CATALOG = buildConf("spark.sql.defaultCatalog") | ||
| .doc("Name of the default catalog. This will be as the current catalog if users have not " + |
Contributor
There was a problem hiding this comment.
This will be the current catalog or will be used/set as
|
Test build #113279 has finished for PR 26395 at commit
|
Contributor
Author
|
retest this please |
|
Test build #113641 has started for PR 26395 at commit |
Contributor
|
+1 |
Contributor
Author
|
retest this please |
|
Test build #113690 has finished for PR 26395 at commit
|
Contributor
Author
|
thanks for review, merging to master! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
rename the config to address the comment: #24594 (comment)
improve the config description, provide a default value to simplify the code.
Why are the changes needed?
make the config more understandable.
Does this PR introduce any user-facing change?
no
How was this patch tested?
existing tests