[SPARK-29743][SQL] sample should set needCopyResult to true if its child is #26387
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
viirya
reviewed
Nov 4, 2019
|
|
||
| override def needCopyResult: Boolean = withReplacement | ||
| override def needCopyResult: Boolean = { | ||
| child.asInstanceOf[CodegenSupport].needCopyResult || withReplacement |
viirya
approved these changes
Nov 4, 2019
Member
|
This bug fix needs to be backported to all the active versions. |
dongjoon-hyun
changed the title
dongjoon-hyun
approved these changes
Nov 4, 2019
Member
dongjoon-hyun
left a comment
dongjoon-hyun
left a comment
There was a problem hiding this comment.
+1, LGTM. Thank you so much, @cloud-fan !
Member
|
I tested the new UT locally, but this PR might break some other |
|
Test build #113212 has finished for PR 26387 at commit
|
Member
|
Merged to master/2.4. Thank you, @cloud-fan , @viirya , @gatorsmile . |
dongjoon-hyun
pushed a commit
that referenced
this pull request
Nov 4, 2019
…ild is `SampleExec` has a bug that it sets `needCopyResult` to false as long as the `withReplacement` parameter is false. This causes problems if its child needs to copy the result, e.g. a join. to fix a correctness issue Yes, the result will be corrected. a new test Closes #26387 from cloud-fan/sample-bug. Authored-by: Wenchen Fan <[email protected]> Signed-off-by: Dongjoon Hyun <[email protected]> (cherry picked from commit 326b789) Signed-off-by: Dongjoon Hyun <[email protected]>
Member
|
oh.. I'm late. LGTM. Anyway, good catch! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
SampleExechas a bug that it setsneedCopyResultto false as long as thewithReplacementparameter is false. This causes problems if its child needs to copy the result, e.g. a join.Why are the changes needed?
to fix a correctness issue
Does this PR introduce any user-facing change?
Yes, the result will be corrected.
How was this patch tested?
a new test