[SPARK-29742][BUILD] Update checkstyle plugin's check dir scope #26385
Conversation
|
ok to test |
pom.xml
Outdated
| <sourceDirectories> | ||
| <directory>${basedir}/src/main/java</directory> | ||
| <directory>${basedir}/src/main/scala</directory> | ||
| <directory>v${hive.version.short}/src/main/java</directory> |
There was a problem hiding this comment.
v${hive.version.short}/src/main/java -> ${basedir}/v${hive.version.short}/src/main/java?
There was a problem hiding this comment.
v${hive.version.short}/src/main/java->${basedir}/v${hive.version.short}/src/main/java?
done
srowen
left a comment
srowen
left a comment
There was a problem hiding this comment.
I think it's OK, if there are few style checks the fix. The minor issue is that some of this code is copied from Hive right? so if we modified it a lot it might be harder to update. But minor changes like this are no big deal.
Not all copied code from hive. sql/core module have some java code in folder v1.2.1/v2.3.5 . |
|
Test build #113210 has finished for PR 26385 at commit
|
|
Test build #113211 has finished for PR 26385 at commit
|
dongjoon-hyun
left a comment
dongjoon-hyun
left a comment
There was a problem hiding this comment.
Yes. Right. +1, LGTM. Thank you, @AngersZhuuuu , @srowen , @wangyum .
Merged to master.
5 participants
What changes were proposed in this pull request?
Current checkstyle checking folder can't cover all folder.
Since for support multi version hive, we have some divided hive folder.
We should check it too.
Why are the changes needed?
Fix build bug
Does this PR introduce any user-facing change?
NO
How was this patch tested?
NO