[SPARK-29739][PYSPARK][TESTS] Use java instead of cc in test_pipe_functions
#26383
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dongjoon-hyun
changed the title
java instead of cc in test_rdd.pyjava instead of cc in test_pipe_functions
|
Test build #113193 has finished for PR 26383 at commit
|
maropu
approved these changes
Nov 4, 2019
dongjoon-hyun
commented
Nov 4, 2019
Member
Author
dongjoon-hyun
left a comment
dongjoon-hyun
left a comment
There was a problem hiding this comment.
Thank you for review and approval, @maropu .
Merged to master.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
This PR aims to replace
ccwithjavaintest_pipe_functionsoftest_rdd.py.Why are the changes needed?
Currently,
test_rdd.pyassumesccinstallation duringrdd.pipetests.This requires us to install
gccfor python testing. If we usejava, we can have the same test coverage and we don't need to install it because it's already installed inPySparktest environment.This will be helpful when we build a dockerized parallel testing environment.
Does this PR introduce any user-facing change?
No.
How was this patch tested?
Pass the existing PySpark tests.