Revert "[SPARK-24152][R][TESTS] Disable check-cran from run-tests.sh" #26381
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 91d9901.
Member
Author
Member
Author
|
Let's check if CRAN check is back. |
|
Test build #113184 has finished for PR 26381 at commit
|
Member
Author
|
The CRAN issue looks resolved now. |
dongjoon-hyun
approved these changes
Nov 3, 2019
Member
There was a problem hiding this comment.
+1, LGTM.
Thank you, @viirya . Merged to master/2.4.
dongjoon-hyun
pushed a commit
that referenced
this pull request
Nov 3, 2019
### What changes were proposed in this pull request? This reverts commit 91d9901. ### Why are the changes needed? CRAN check is pretty important for R package, we should enable it. ### Does this PR introduce any user-facing change? No ### How was this patch tested? Unit tests. Closes #26381 from viirya/revert-SPARK-24152. Authored-by: Liang-Chi Hsieh <[email protected]> Signed-off-by: Dongjoon Hyun <[email protected]> (cherry picked from commit e726324) Signed-off-by: Dongjoon Hyun <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
This reverts commit 91d9901.
Why are the changes needed?
CRAN check is pretty important for R package, we should enable it.
Does this PR introduce any user-facing change?
No
How was this patch tested?
Unit tests.