Skip to content

Conversation

@dongjoon-hyun
Copy link
Member

@dongjoon-hyun dongjoon-hyun commented Nov 3, 2019

What changes were proposed in this pull request?

This PR replaces jira_client API call for read-only access with public Apache JIRA REST API invocation.

Why are the changes needed?

This will reduce the number of authenticated API invocations. I hope this will reduce the chance of CAPCHAR from Apache JIRA site.

Does this PR introduce any user-facing change?

No.

How was this patch tested?

Manual.

$ echo 26375 > .github-jira-max
$ dev/github_jira_sync.py
Read largest PR number previously seen: 26375
Retrieved 100 JIRA PR's from Github
1 PR's remain after excluding visted ones
Checking issue SPARK-29731
Writing largest PR number seen: 26376
Build PR dictionary
SPARK-29731
26376
Set 26376 with labels "PROJECT INFRA"

@SparkQA
Copy link

SparkQA commented Nov 3, 2019

Test build #113151 has finished for PR 26376 at commit 877e007.

  • This patch fails SparkR unit tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@dongjoon-hyun
Copy link
Member Author

Retest this please.

@SparkQA
Copy link

SparkQA commented Nov 3, 2019

Test build #113153 has finished for PR 26376 at commit 877e007.

  • This patch fails Spark unit tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@dongjoon-hyun
Copy link
Member Author

Retest this please.

@srowen
Copy link
Member

srowen commented Nov 3, 2019

Seems fine if it works the same way. I don't know if it will help or not, but does seem a little simpler.

@dongjoon-hyun
Copy link
Member Author

Thank you for review, @srowen .

@dongjoon-hyun
Copy link
Member Author

Oops. I added a wrong commit and recover it immediately by removing it. There is no change on this PR. It's the same with the first commit.

@SparkQA
Copy link

SparkQA commented Nov 3, 2019

Test build #113176 has finished for PR 26376 at commit 877e007.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@dongjoon-hyun
Copy link
Member Author

The changed code part works in the same way for that code part. I tested it manually. For the other parts, the current GitHub favicon seems to be invalid. I'll handle that later in another PR.
Merged to master.

@dongjoon-hyun dongjoon-hyun deleted the SPARK-29731 branch November 3, 2019 19:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants