[SPARK-29678][SQL] ALTER TABLE (ADD PARTITION) should look up catalog/table like v2 commands #26369
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
imback82
commented
Nov 2, 2019
| | ALTER TABLE tableIdentifier (partitionSpec)? | ||
| SET SERDEPROPERTIES tablePropertyList #setTableSerDe | ||
| | ALTER TABLE tableIdentifier ADD (IF NOT EXISTS)? | ||
| | ALTER (TABLE | VIEW) multipartIdentifier ADD (IF NOT EXISTS)? |
Contributor
Author
There was a problem hiding this comment.
I am combining these two since ALTER VIEW is not supported for ADD PARTITION and this rule is compatible with the view rule.
| spec -> location | ||
| } | ||
| } else { | ||
| // Alter View: the location clauses are not allowed. |
Contributor
Author
There was a problem hiding this comment.
I also removed this check in ASTBuilder.scala since view check is already done at the top.
|
Test build #113132 has finished for PR 26369 at commit
|
Contributor
Author
|
retest this please |
|
Test build #113138 has finished for PR 26369 at commit
|
Contributor
Author
|
retest this please |
|
Test build #113155 has finished for PR 26369 at commit
|
Contributor
Author
|
retest this please |
|
Test build #113174 has finished for PR 26369 at commit
|
Contributor
Author
|
cc: @cloud-fan @viirya |
Contributor
|
thanks, merging to master! |
Member
|
lgtm |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Add AlterTableAddPartitionStatement and make ALTER TABLE ... ADD PARTITION go through the same catalog/table resolution framework of v2 commands.
Why are the changes needed?
It's important to make all the commands have the same table resolution behavior, to avoid confusing end-users. e.g.
Does this PR introduce any user-facing change?
Yes. When running ALTER TABLE ... ADD PARTITION, Spark fails the command if the current catalog is set to a v2 catalog, or the table name specified a v2 catalog.
How was this patch tested?
Unit tests