[SPARK-29353][SQL] Fallback AlterTableAlterColumnStatement to v1 AlterTableChangeColumnCommand #26354
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AlterTableChangeColumnCommand for v1 tables.
|
Test build #113080 has finished for PR 26354 at commit
|
viirya
commented
Nov 1, 2019
Comment on lines
+69
to
+72
| if (dataType.isEmpty) { | ||
| throw new AnalysisException( | ||
| "ALTER COLUMN with v1 tables must specify new data type.") | ||
| } |
Member
Author
There was a problem hiding this comment.
Alternative option is, we may find out the datatype of given column and just use it.
Member
Author
|
cc @cloud-fan |
Contributor
|
thanks, merging to master! |
cloud-fan
pushed a commit
that referenced
this pull request
Nov 6, 2019
### What changes were proposed in this pull request? This patch removes v1 ALTER TABLE CHANGE COLUMN syntax. ### Why are the changes needed? Since in v2 we have ALTER TABLE CHANGE COLUMN and ALTER TABLE RENAME COLUMN, this old syntax is not necessary now and can be confusing. The v2 ALTER TABLE CHANGE COLUMN should fallback to v1 AlterTableChangeColumnCommand (#26354). ### Does this PR introduce any user-facing change? Yes, the old v1 ALTER TABLE CHANGE COLUMN syntax is removed. ### How was this patch tested? Unit tests. Closes #26338 from viirya/SPARK-29680. Authored-by: Liang-Chi Hsieh <[email protected]> Signed-off-by: Wenchen Fan <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
If the resolved table is v1 table, AlterTableAlterColumnStatement fallbacks to v1 AlterTableChangeColumnCommand.
Why are the changes needed?
To make the catalog/table lookup logic consistent.
Does this PR introduce any user-facing change?
Yes, a ALTER TABLE ALTER COLUMN command previously fails on v1 tables. After this, it falls back to v1 AlterTableChangeColumnCommand.
How was this patch tested?
Unit test.