Skip to content

[SPARK-29590][WEBUI]JDBC/ODBC tab in the spark UI support hide tables, to make it consistent with other tabs. #26353

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
shahidki31 wants to merge 3 commits into from
Closed

[SPARK-29590][WEBUI]JDBC/ODBC tab in the spark UI support hide tables, to make it consistent with other tabs. #26353

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
1b1c0a0
support collapse table
shahidki31 Nov 1, 2019
e86b15a
Merge branch 'master' of https://github.com/apache/spark into hideTable
shahidki31 Nov 1, 2019
4271589
fix
shahidki31 Nov 2, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions core/src/main/resources/org/apache/spark/ui/static/webui.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -87,6 +87,9 @@ $(function() {
collapseTablePageLoad('collapse-aggregated-runningExecutions','aggregated-runningExecutions');
collapseTablePageLoad('collapse-aggregated-completedExecutions','aggregated-completedExecutions');
collapseTablePageLoad('collapse-aggregated-failedExecutions','aggregated-failedExecutions');
collapseTablePageLoad('collapse-aggregated-sessionstat','aggregated-sessionstat');
collapseTablePageLoad('collapse-aggregated-sqlstat','aggregated-sqlstat');
collapseTablePageLoad('collapse-aggregated-sqlsessionstat','aggregated-sqlsessionstat');
});

$(function() {
Expand Down
32 changes: 20 additions & 12 deletions ...iftserver/src/main/scala/org/apache/spark/sql/hive/thriftserver/ui/ThriftServerPage.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -124,15 +124,18 @@ private[ui] class ThriftServerPage(parent: ThriftServerTab) extends WebUIPage(""
} else {
None
}

val content =
<h5 id="sqlstat">SQL Statistics ({numStatement})</h5> ++
<div>
<ul class="unstyled">
{table.getOrElse("No statistics have been generated yet.")}
</ul>
<span id="sqlstat" class="collapse-aggregated-sqlstat collapse-table"
onClick="collapseTable('collapse-aggregated-sqlstat',
'aggregated-sqlstat')">
<h4>
<span class="collapse-table-arrow arrow-open"></span>
<a>SQL Statistics ({numStatement})</a>
</h4>
</span> ++
<div class="aggregated-sqlstat collapsible-table">
{table.getOrElse("No statistics have been generated yet.")}
</div>

content
}

Expand Down Expand Up @@ -191,11 +194,16 @@ private[ui] class ThriftServerPage(parent: ThriftServerTab) extends WebUIPage(""
}

val content =
<h5 id="sessionstat">Session Statistics ({numSessions})</h5> ++
<div>
<ul class="unstyled">
{table.getOrElse("No statistics have been generated yet.")}
</ul>
<span id="sessionstat" class="collapse-aggregated-sessionstat collapse-table"
onClick="collapseTable('collapse-aggregated-sessionstat',
'aggregated-sessionstat')">
<h4>
<span class="collapse-table-arrow arrow-open"></span>
<a>Session Statistics ({numSessions})</a>
</h4>
</span> ++
<div class="aggregated-sessionstat collapsible-table">
{table.getOrElse("No statistics have been generated yet.")}
</div>

content
Expand Down
16 changes: 10 additions & 6 deletions ...er/src/main/scala/org/apache/spark/sql/hive/thriftserver/ui/ThriftServerSessionPage.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -126,13 +126,17 @@ private[ui] class ThriftServerSessionPage(parent: ThriftServerTab)
} else {
None
}

val content =
<h5>SQL Statistics</h5> ++
<div>
<ul class="unstyled">
{table.getOrElse("No statistics have been generated yet.")}
</ul>
<span id="sqlsessionstat" class="collapse-aggregated-sqlsessionstat collapse-table"
onClick="collapseTable('collapse-aggregated-sqlsessionstat',
'aggregated-sqlsessionstat')">
<h4>
<span class="collapse-table-arrow arrow-open"></span>
<a>SQL Statistics</a>
</h4>
</span> ++
<div class="aggregated-sqlsessionstat collapsible-table">
{table.getOrElse("No statistics have been generated yet.")}
</div>

content
Expand Down