Skip to content

[SPARK-29687][SQL] Fix JDBC metrics counter data type #26346

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
ulysses-you wants to merge 1 commit into from
Closed

[SPARK-29687][SQL] Fix JDBC metrics counter data type #26346

ulysses-you wants to merge 1 commit into from

Conversation

@ulysses-you
Copy link
Contributor

@ulysses-you ulysses-you commented Oct 31, 2019 •
edited
Loading

What changes were proposed in this pull request?

Fix JDBC metrics counter data type. Related pull request 26109.

Why are the changes needed?

Avoid overflow.

Does this PR introduce any user-facing change?

No.

How was this patch tested?

Exists UT.

@ulysses-you
Copy link
Contributor Author

ulysses-you commented Oct 31, 2019

cc @HeartSaVioR @HyukjinKwon @maropu

HeartSaVioR
HeartSaVioR approved these changes Oct 31, 2019
View reviewed changes
Copy link
Contributor

@HeartSaVioR HeartSaVioR left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@SparkQA
Copy link

SparkQA commented Oct 31, 2019

Test build #4909 has finished for PR 26346 at commit fb4eeb0.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

maropu
maropu approved these changes Oct 31, 2019
View reviewed changes
Copy link
Member

@maropu maropu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ur, I see. Nice catch. LGTM

@maropu maropu closed this in 8a8ac00 Oct 31, 2019
@maropu
Copy link
Member

maropu commented Oct 31, 2019

Thanks! Merged to master.

@ulysses-you
Copy link
Contributor Author

ulysses-you commented Oct 31, 2019

Thanks all !

@ulysses-you ulysses-you deleted the SPARK-29687 branch June 21, 2021 05:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@maropu maropu maropu approved these changes

@srowen srowen srowen approved these changes

@HeartSaVioR HeartSaVioR HeartSaVioR approved these changes

Assignees

No one assigned

Labels

SQL

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@ulysses-you @SparkQA @maropu @srowen @HeartSaVioR @dongjoon-hyun